Fix ArgumentNullException when Generating without docs -NoDocs switch#711
Merged
dolauli merged 2 commits intoAzure:masterfrom Nov 20, 2020
georgend:master
Merged
Fix ArgumentNullException when Generating without docs -NoDocs switch#711dolauli merged 2 commits intoAzure:masterfrom georgend:master
-NoDocs switch#711dolauli merged 2 commits intoAzure:masterfrom
georgend:master
Conversation
added 2 commits
November 18, 2020 16:10
…ures. Pass along `-ExamplesFolder` since its required in all code paths.
peombwa
reviewed
Nov 18, 2020
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
dolauli
pushed a commit
to dolauli/autorest.powershell
that referenced
this pull request
Nov 23, 2020
…ch (Azure#711) * Fix ArgumentNullException when Generating without docs `-NoDocs` features. Pass along `-ExamplesFolder` since its required in all code paths. * Make examples mandatory, for all paramsets Co-authored-by: George Ndungu <gendungu@microsoft.com>
dolauli
added a commit
that referenced
this pull request
Nov 23, 2020
…ch (#711) (#712) * Fix ArgumentNullException when Generating without docs `-NoDocs` features. Pass along `-ExamplesFolder` since its required in all code paths. * Make examples mandatory, for all paramsets Co-authored-by: George Ndungu <gendungu@microsoft.com> Co-authored-by: George <1641829+finsharp@users.noreply.github.com> Co-authored-by: George Ndungu <gendungu@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the code path below, throws
ArgumentNullExceptionwhenExport-ProxyCmdletis invoked in the-NoDocscode path.autorest.powershell/powershell/resources/assets/build-module.ps1
Lines 123 to 134 in f9b8e88
Exception is thrown here at
Path.Combine, sinceExamplesFolderwill be null.autorest.powershell/powershell/resources/psruntime/BuildTime/Cmdlets/ExportProxyCmdlet.cs
Line 76 in 6390998
Solution
Allow
ExamplesFolderto be passed along for all param sets, since examples are already always generated. (Example Stubs).autorest.powershell/powershell/resources/psruntime/BuildTime/Cmdlets/ExportProxyCmdlet.cs
Lines 45 to 47 in 6390998
Pass along
-ExamplesFoldersince its required in all code paths.