Skip to content

Fix waagent overriding SSH public key from Ignition configuration #3309

Merged
maddieford merged 1 commit intoAzure:developfrom
peytonr18:patch-ssh-public-key-override
Jan 28, 2025
Merged

Fix waagent overriding SSH public key from Ignition configuration #3309
maddieford merged 1 commit intoAzure:developfrom
peytonr18:patch-ssh-public-key-override

Conversation

@peytonr18
Copy link
Copy Markdown
Contributor

Description

This PR resolves an issue where the WALinuxAgent overrides the SSH public key provided by Ignition configuration during provisioning. The issue is related to this ongoing ICM, and applies the fix given for resolving the issue.

Issue #


PR information

  • Ensure development PR is based on the develop branch.
  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made

Quality of Code and Contribution Guidelines

@maddieford
Copy link
Copy Markdown
Contributor

@jasonzio Could we please get your review on this one too?

Copy link
Copy Markdown
Member

@jasonzio jasonzio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I observed test results where this change was made to a dev fork; the "right thing" happened, and nothing else broke.

@maddieford maddieford merged commit 0c8db73 into Azure:develop Jan 28, 2025
dongsupark added a commit to flatcar/scripts that referenced this pull request Feb 26, 2025
Apply patch to fix an issue when overriding ssh public key from ignition
configuration. Since the fix is not available in releases of
wa-linux-agent, we should apply a separate patch.

See also Azure/WALinuxAgent#3309.
dongsupark added a commit to flatcar/scripts that referenced this pull request Feb 26, 2025
Apply patch to fix an issue when overriding ssh public key from ignition
configuration. Since the fix is not available in releases of
wa-linux-agent, we should apply a separate patch.

See also Azure/WALinuxAgent#3309.
dongsupark added a commit to flatcar/scripts that referenced this pull request Feb 28, 2025
Apply patch to fix an issue when overriding ssh public key from ignition
configuration. Since the fix is not available in releases of
wa-linux-agent, we should apply a separate patch.

See also Azure/WALinuxAgent#3309.
dongsupark added a commit to flatcar/scripts that referenced this pull request Feb 28, 2025
Apply patch to fix an issue when overriding ssh public key from ignition
configuration. Since the fix is not available in releases of
wa-linux-agent, we should apply a separate patch.

See also Azure/WALinuxAgent#3309.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants