Skip to content

AAD Brute Force Hunting query#3601

Merged
aprakash13 merged 8 commits into
Azure:masterfrom
cmaneiro:cmaneiro
Jan 7, 2022
Merged

AAD Brute Force Hunting query#3601
aprakash13 merged 8 commits into
Azure:masterfrom
cmaneiro:cmaneiro

Conversation

@cmaneiro

@cmaneiro cmaneiro commented Dec 2, 2021

Copy link
Copy Markdown
Contributor

Proposed Changes

  • Include a new hunting query for AAD Brute Force

@cmaneiro

cmaneiro commented Dec 3, 2021

Copy link
Copy Markdown
Contributor Author

Hi @shainw

Not sure what is failing in this file!

Could you please let me know what is wrong to fix it?

Regards

@cmaneiro cmaneiro mentioned this pull request Dec 6, 2021
Closed
samikroy added a commit to samikroy/Azure-Sentinel that referenced this pull request Dec 7, 2021
@samikroy
AADSuspectedBruteForce.yaml
400e37f 
Testing for Azure#3601
@samikroy samikroy mentioned this pull request Dec 7, 2021
Closed
@v-sabiraj

v-sabiraj commented Dec 8, 2021

Copy link
Copy Markdown
Contributor

Hey @cmaneiro, We have resolved the issue for PR Validations failure and request you to please update your PR branch with the latest changes from Azure:master so that the PR Validations can be executed.... Thanks!!!

@cmaneiro

cmaneiro commented Dec 8, 2021

Copy link
Copy Markdown
Contributor Author

Hey @cmaneiro, We have resolved the issue for PR Validations failure and request you to please update your PR branch with the latest changes from Azure:master so that the PR Validations can be executed.... Thanks!!!

hi @v-sabiraj

All validation pass!!! coul you please close #3634 which is a duplicated!

Regards

@cmaneiro

cmaneiro commented Dec 29, 2021

Copy link
Copy Markdown
Contributor Author

Hi @aprakash13 and @shainw

I've update the HQ according to comment in #3634 could you please close #3634 and keep working in this PR? the other one was a test that I'm not the owner.

Regards

@shainw shainw added the Hunting Hunting specialty review needed label Dec 30, 2021
@cmaneiro

cmaneiro commented Jan 7, 2022

Copy link
Copy Markdown
Contributor Author

Hi @shainw, @aprakash13

Any update on this PR? All the requested changes has been implemented.

Regards

aprakash13
aprakash13 approved these changes Jan 7, 2022
View reviewed changes

@aprakash13 aprakash13 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The query looks good. Approved.

@aprakash13 aprakash13 merged commit 8330ddf into Azure:master Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Amitbergman Amitbergman Awaiting requested review from Amitbergman

@ashwin-patil ashwin-patil Awaiting requested review from ashwin-patil

@dicolanl dicolanl Awaiting requested review from dicolanl

@ianhelle ianhelle Awaiting requested review from ianhelle

@juliango2100 juliango2100 Awaiting requested review from juliango2100

@laithhisham laithhisham Awaiting requested review from laithhisham

@liatlishams liatlishams Awaiting requested review from liatlishams

@liemilyg liemilyg Awaiting requested review from liemilyg

@lior-tamir lior-tamir Awaiting requested review from lior-tamir

@mgladi mgladi Awaiting requested review from mgladi

@nazang nazang Awaiting requested review from nazang

@NoamLandress NoamLandress Awaiting requested review from NoamLandress

@oshezaf oshezaf Awaiting requested review from oshezaf

@oshvartz oshvartz Awaiting requested review from oshvartz

@petebryan petebryan Awaiting requested review from petebryan

@preetikr preetikr Awaiting requested review from preetikr

@sagamzu sagamzu Awaiting requested review from sagamzu

@sarah-yo sarah-yo Awaiting requested review from sarah-yo

@shainw shainw Awaiting requested review from shainw

@shschwar shschwar Awaiting requested review from shschwar

@sreedharande sreedharande Awaiting requested review from sreedharande

@timbMSFT timbMSFT Awaiting requested review from timbMSFT

@Yaniv-Shasha Yaniv-Shasha Awaiting requested review from Yaniv-Shasha

@YaronFruchtmann YaronFruchtmann Awaiting requested review from YaronFruchtmann

@YuvalNaor YuvalNaor Awaiting requested review from YuvalNaor

1 more reviewer

@aprakash13 aprakash13 aprakash13 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@aprakash13 aprakash13

Labels

Hunting Hunting specialty review needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cmaneiro @v-sabiraj @aprakash13 @shainw