Merged
Conversation
apparently the class password hash isnt yet present when trying to access it, maybe a newer version changed it.
~~~
[23-Oct-2017 08:28:42 UTC] PHP Fatal error: Uncaught Error: Class 'PasswordHash' not found in /home/my1devcon/public_html/wptest/wp-content/plugins/password-hash-disabled/wp-php-password-hash.php:64
Stack trace:
#0 /home/my1devcon/public_html/wptest/wp-includes/user.php(162): wp_check_password('test', '$P$BzCPKMBr7KO3...', 1)
#1 /home/my1devcon/public_html/wptest/wp-includes/class-wp-hook.php(298): wp_authenticate_username_password(Object(WP_User), 'My1', 'test')
Ayesh#2 /home/my1devcon/public_html/wptest/wp-includes/plugin.php(203): WP_Hook->apply_filters(NULL, Array)
Ayesh#3 /home/my1devcon/public_html/wptest/wp-includes/pluggable.php(532): apply_filters('authenticate', NULL, 'My1', 'test')
Ayesh#4 /home/my1devcon/public_html/wptest/wp-includes/user.php(85): wp_authenticate('My1', 'test')
Ayesh#5 /home/my1devcon/public_html/wptest/wp-login.php(790): wp_signon(Array, true)
Ayesh#6 {main}
thrown in /home/my1devcon/public_html/wptest/wp-content/plugins/password-hash-disabled/wp-php-password-hash.php on line 64
~~~
Contributor
Author
|
sure took a while especially considering the plugin description on WP says tested up to 4.9.1, which is evidently not the case. |
Owner
|
It took a while, yes. Sorry about that :( I have a Wordpress dev-master installation that I use to test the plugins. This wasn't caught for some reason. We'll get to the Argon2i issue (#1 soon) too. Thanks for the PR. It helped a lot. |
Contributor
Author
|
WTF in the master it worked but not in the release? why that, that sounds crazy. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
apparently the class password hash isnt yet present when trying to access it, maybe a newer version changed it.