fix(chats): rename "Private Message" placeholder to "Direct Message"#234
Merged
Merged
Conversation
Aligns chat input placeholder text with the terminology used throughout the MeshCore ecosystem. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Owner
|
I agree this is a change worth making in the future. Before doing this, I would like to add a visual indicator to let the user know at a glance whether they are sending an encrypted private message or not. Perhaps a padlock icon. Could you create an issue for this renaming? When I get around to it, I would like to make this change so I can replace all the translations as well. |
Contributor
Author
|
Issue added as #237 . |
Owner
|
Padlocks added in 31a885a, so I can merge this now. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Chats.strings: Updated localization stringchats.input.placeholder.directMessageL10n.swift: Regenerated via SwiftGenTest plan
swiftlint lintpasses with no new warnings🤖 Generated with Claude Code