feat: Persistent Launcher instances and Async UI updates #1231
+71
−28
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR refactors how Launcher plugins are handled to support state persistence and asynchronous UI updates. Previously, Launcher plugins were instantiated and destroyed for every single query, preventing them from maintaining internal state or performing async tasks.
Concrete Example: The Qalculate Plugin
This refactoring was driven by the needs of advanced plugins like Qalculate.
qalcprocess alive for instant performance. Without this PR, the process would be killed and restarted at every keystroke.Key Changes
Persistent Launcher Instances:
PluginService.pluginInstances, similar toDaemons.Asynchronous UI Updates:
requestLauncherUpdate(pluginId)signal inPluginService.AppLaunchernow listens to this signal to trigger a refresh. Plugins can now update the items list at any time, not just during the initial query.AppSearchService Optimization:
AppSearchServicenow reuses the persistent instance fromPluginService.Dependency Injection:
PluginServicesingleton is injected into plugins during creation (pluginService: root), enabling easier access to shared services and data.Why this is needed
This architecture is essential for any plugin that interacts with external binaries, APIs, or performs heavy computations. It makes the launcher capable of handling non-instant results while remaining fluid for the user.