Merged
Conversation
Fixes #103 The readme suggests setting up keys in `wp-config.php`, and suggests using comments like `-----BEGIN RSA PUBLIC KEY-----` to clearly mark the beginning and end of your key. However, that format: 1. Does not match the output of the `openssl` command. 2. Does not match the format we expect in Tools > Site Health: https://github.com/Automattic/wp-openid-connect-server/blob/ee663a12d9e12d0b5c9e8c7745c3b48c716754b2/src/SiteStatusTests.php#L35 Let's update the example format to match what's expected.
Member
|
@jeherve Thanks for your contribution! Indeed the output doesn't have RSA keyword in PEM headers when I tried running openssl on mac and on linux. So, I am going to merge this PR so that readme reflects it better and also following up with another PR to improve the key detection so that if someone has RSA keyword in PEM headers, it doesn't raise an alarm for that. |
ashfame
approved these changes
Oct 26, 2023
ashfame
added a commit
that referenced
this pull request
Oct 26, 2023
ashfame
added a commit
that referenced
this pull request
Nov 2, 2023
fix readme for private key example as done in #104
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #103
The readme suggests setting up keys in
wp-config.php, and suggests using comments like-----BEGIN RSA PUBLIC KEY-----to clearly mark the beginning and end of your key.However, that format:
opensslcommand.wp-openid-connect-server/src/SiteStatusTests.php
Line 35 in ee663a1
Let's update the example format to match what's expected.