feat: add unique icons repository and remove custom icons by thomasguillot · Pull Request #3883 · Automattic/newspack-plugin

thomasguillot · 2025-04-03T15:32:28Z

All Submissions:

Have you followed the Newspack Contributing guideline?
Does your code follow the WordPress' coding standards and VIP Go coding standards?
Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changes proposed in this Pull Request:

We now have an /src/icons/ containing ALL the custom Newspack icons (see Figma)
The idea is in the future we create an NPM package so we can easily include these icons in our plugins and we only have to maintain them in one place
I've removed all the custom icons I could find, and replaced them with the new icons. This includes:
- Dashboard
- Prompts
- Corrections block
- Reader registration block

How to test the changes in this Pull Request:

Switch to this branch
Check if all the affected wizards still work and display the correct icon
Check if all the affected blocks still work and display the correct icon

Other information:

Have you added an explanation of what your changes do and why you'd like us to include them?
Have you written new tests for your changes, as applicable?
Have you successfully ran tests with your changes locally?

dkoo

Not seeing anything broken, and I love the consolidation of all custom icons in a single place. I did see a few <svg> elements floating around the dashboard pages that were maybe missed:

If the ultimate goal is to create an NPM package for this, creating it as a separate repo might be a good idea instead of bundling it into this plugin (I know we do this for Newspack Components, but it causes some confusion).

thomasguillot · 2025-05-15T09:39:01Z

@dkoo I tried updating https://github.com/Automattic/newspack-plugin/blob/add/icons/src/bylines/index.js#L27 but I'm not sure how I can use a button component in this markup (even Cursor is confused). The code for this feature is an absolute mess (inc. the CSS)
I was only able to make a small tweak 449ca6b

thomasguillot · 2025-05-15T09:40:24Z

@dkoo https://github.com/Automattic/newspack-plugin/blob/add/icons/src/components/src/newspack-icon/index.js#L34 This is the newspack icon as a component so this we're not modifying it

thomasguillot · 2025-05-15T09:48:54Z

@dkoo Same with https://github.com/Automattic/newspack-plugin/blob/add/icons/src/plugins-screen/plugins-screen.js#L56 I wasn't able to use a component.
I did make a small change though 876af50

thomasguillot · 2025-05-15T09:51:39Z

If the ultimate goal is to create an NPM package for this, creating it as a separate repo might be a good idea instead of bundling it into this plugin (I know we do this for Newspack Components, but it causes some confusion).

How could that be done? Would a separate PR make sense?

I was thinking of following Gutenberg’s example, where all packages are organised in one place: https://github.com/WordPress/gutenberg/tree/trunk/packages.

dkoo · 2025-05-15T15:39:02Z

How could that be done? Would a separate PR make sense?

I was thinking of following Gutenberg’s example, where all packages are organised in one place: https://github.com/WordPress/gutenberg/tree/trunk/packages.

Gotcha, in that case this is a fine way to do things. Nevermind!

github-actions · 2025-05-16T08:54:43Z

Hey @thomasguillot, good job getting this PR merged! 🎉

Now, the needs-changelog label has been added to it.

Please check if this PR needs to be included in the "Upcoming Changes" and "Release Notes" doc. If it doesn't, simply remove the label.

If it does, please add an entry to our shared document, with screenshots and testing instructions if applicable, then remove the label.

Thank you! ❤️

# [6.7.0-alpha.1](v6.6.2...v6.7.0-alpha.1) (2025-05-23) ### Bug Fixes * **404-images:** use JS without modifying content ([#3963](#3963)) ([9f5646b](9f5646b)) * add missing namespace ([#3980](#3980)) ([6d58793](6d58793)) * **emails:** add missing HTML markup in the change-email-cancel template ([#3981](#3981)) ([040ae30](040ae30)) * **ga4:** fire login/registration activities via SSO ([#3965](#3965)) ([8c97515](8c97515)) * hide modal content gate when modal checkout is opened ([#3953](#3953)) ([a503973](a503973)) * **jetpack:** handle the related posts max age option ([#3964](#3964)) ([8aad2b8](8aad2b8)) * make sure fix duplcate fields apply filters ([#3971](#3971)) ([f361a4e](f361a4e)) * namespace Lite Site ([#3975](#3975)) ([e4665ae](e4665ae)) * sync correction status with parent post status ([#3978](#3978)) ([dcd5a12](dcd5a12)) ### Features * add compatibility to network in custom bylines ([#3972](#3972)) ([199a993](199a993)) * add icons repository and remove custom icons ([#3883](#3883)) ([e56d2e0](e56d2e0)) * **analytics:** "My Account" dashboard interactions ([#3949](#3949)) ([22e9590](22e9590)) * **donations:** update notice style and type ([#3962](#3962)) ([3f60ef3](3f60ef3)) * **email-change:** remove env constant requirement ([#3943](#3943)) ([4158bf1](4158bf1)) * **my-account:** apply Newspack UI styles to My Account w/ env constant ([#3951](#3951)) ([e4aa5a2](e4aa5a2)) * **my-account:** full-site takeover template and custom nav menu ([#3974](#3974)) ([5cf8403](5cf8403)) * **woocommerce:** log error notices ([#3952](#3952)) ([1654007](1654007))

matticbot · 2025-05-23T15:45:55Z

🎉 This PR is included in version 6.7.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

# [6.7.0](v6.6.4...v6.7.0) (2025-06-02) ### Bug Fixes * **404-images:** use JS without modifying content ([#3963](#3963)) ([9f5646b](9f5646b)) * add missing namespace ([#3980](#3980)) ([6d58793](6d58793)) * **emails:** add missing HTML markup in the change-email-cancel template ([#3981](#3981)) ([040ae30](040ae30)) * **ga4:** fire login/registration activities via SSO ([#3965](#3965)) ([8c97515](8c97515)) * hide modal content gate when modal checkout is opened ([#3953](#3953)) ([a503973](a503973)) * **jetpack:** handle the related posts max age option ([#3964](#3964)) ([8aad2b8](8aad2b8)) * make sure fix duplcate fields apply filters ([#3971](#3971)) ([f361a4e](f361a4e)) * namespace Lite Site ([#3975](#3975)) ([e4665ae](e4665ae)) * prevent auto-publishing corrections when scheduling posts ([#4006](#4006)) ([7531832](7531832)) * sync correction status with parent post status ([#3978](#3978)) ([dcd5a12](dcd5a12)) ### Features * add compatibility to network in custom bylines ([#3972](#3972)) ([199a993](199a993)) * add icons repository and remove custom icons ([#3883](#3883)) ([e56d2e0](e56d2e0)) * **analytics:** "My Account" dashboard interactions ([#3949](#3949)) ([22e9590](22e9590)) * **donations:** update notice style and type ([#3962](#3962)) ([3f60ef3](3f60ef3)) * **email-change:** remove env constant requirement ([#3943](#3943)) ([4158bf1](4158bf1)) * **my-account:** apply Newspack UI styles to My Account w/ env constant ([#3951](#3951)) ([e4aa5a2](e4aa5a2)) * **my-account:** full-site takeover template and custom nav menu ([#3974](#3974)) ([5cf8403](5cf8403)) * **woocommerce:** log error notices ([#3952](#3952)) ([1654007](1654007))

matticbot · 2025-06-02T19:34:34Z

🎉 This PR is included in version 6.7.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

feat: add unique icons repository and remove custom icons

3bacbdf

thomasguillot added the [Status] Needs Review The issue or pull request needs to be reviewed label Apr 3, 2025

thomasguillot requested a review from a team as a code owner April 3, 2025 15:32

thomasguillot added 2 commits April 24, 2025 15:46

Merge trunk into add/icons

118b112

fix: lost icons during merge

51829d2

dkoo requested changes May 14, 2025

View reviewed changes

thomasguillot added 2 commits May 15, 2025 09:30

Merge trunk into add/icons

3fee964

feat: update byline icon

449ca6b

feat: update close icon to match Core's

876af50

dkoo approved these changes May 15, 2025

View reviewed changes

github-actions Bot added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels May 15, 2025

thomasguillot merged commit e56d2e0 into trunk May 16, 2025
8 checks passed

thomasguillot deleted the add/icons branch May 16, 2025 08:54

github-actions Bot added the needs-changelog label May 16, 2025

thomasguillot removed the needs-changelog label May 16, 2025

matticbot added the released on @alpha label May 23, 2025

matticbot added the released label Jun 2, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add unique icons repository and remove custom icons#3883

feat: add unique icons repository and remove custom icons#3883
thomasguillot merged 6 commits into
trunkfrom
add/icons

thomasguillot commented Apr 3, 2025

Uh oh!

dkoo left a comment

Uh oh!

thomasguillot commented May 15, 2025

Uh oh!

thomasguillot commented May 15, 2025

Uh oh!

thomasguillot commented May 15, 2025

Uh oh!

thomasguillot commented May 15, 2025

Uh oh!

dkoo commented May 15, 2025

Uh oh!

Uh oh!

github-actions Bot commented May 16, 2025

Uh oh!

matticbot commented May 23, 2025

Uh oh!

matticbot commented Jun 2, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

thomasguillot commented Apr 3, 2025

All Submissions:

Changes proposed in this Pull Request:

How to test the changes in this Pull Request:

Other information:

Uh oh!

dkoo left a comment

Choose a reason for hiding this comment

Uh oh!

thomasguillot commented May 15, 2025

Uh oh!

thomasguillot commented May 15, 2025

Uh oh!

thomasguillot commented May 15, 2025

Uh oh!

thomasguillot commented May 15, 2025

Uh oh!

dkoo commented May 15, 2025

Uh oh!

Uh oh!

github-actions Bot commented May 16, 2025

Uh oh!

matticbot commented May 23, 2025

Uh oh!

matticbot commented Jun 2, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants