feat(correction-blocks): Correction box & Loop item + Template by Takshil-Kunadia · Pull Request #3787 · Automattic/newspack-plugin

Takshil-Kunadia · 2025-02-28T08:01:26Z

All Submissions:

Have you followed the Newspack Contributing guideline?
Does your code follow the WordPress' coding standards and VIP Go coding standards?
Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changes proposed in this Pull Request:

Closes https://app.asana.com/0/1209292256643614/1209292256643625

How to test the changes in this Pull Request:

Testing Corrections Box Block:-

Create a post add corrections/clarifications.
Add Corrections box block to see the corrections.
Save the post and view the corrections on the front-end.
Modify the corrections on the editor/Add new corrections and click on refresh button to view updated corrections.

Testing Corrections Loop Block Pattern:-

Create a new Page and click + > Patterns Corrections Loop.
Edit the template to change the title/description.
Save & view the page on front-end.

Testing Corrections Archive Block Template:-

Go to Site editor > Template > Search "Corrections" > "Corrections Archive".
Edit the template to replace Header & Footer / change the title/description.
Create a new Page and Select Corrections Archive template.
Save & view the page on front-end.

For individual testing of the Corrections Loop item block

Add a Query Loop block and add Post Template and Pagination blocks inside it.
In Post Template block, Add correction Item block.
Set Post type as Corrections in Query Loop block settings. Per page count can also be set here.
View the corrections archive.

Other information:

Have you added an explanation of what your changes do and why you'd like us to include them?
Have you written new tests for your changes, as applicable?
Have you successfully ran tests with your changes locally?

thomasguillot

It’s working well! Just a couple of changes:

The timezone isn’t needed
The template and pattern strings should be translatable
This should be restricted to Block Themes only

…larifications text

Takshil-Kunadia · 2025-03-03T10:53:41Z

Thanks! @leogermani @thomasguillot for taking a look 🙇 .

The timezone isn’t needed

Removed the timezone from heading ✅

The template and pattern strings should be translatable

Wrapped strings in gettext fns. ✅

This should be restricted to Block Themes only

Assuming this is in reference to the Pattern & Template, yes they will only be registered on block themes.

newspack-plugin/includes/corrections/class-corrections.php

Lines 554 to 556 in 45ff164

    
           public static function register_corrections_block_patterns() { 
        
           	if ( ! class_exists( 'WP_Block_Patterns_Registry' ) || ! wp_is_block_theme() ) { 
        
           		return;

newspack-plugin/includes/corrections/class-corrections.php

Lines 597 to 599 in 45ff164

    
           public static function register_corrections_template() { 
        
           	if ( ! class_exists( 'WP_Block_Templates_Registry' ) || ! wp_is_block_theme() ) { 
        
           		return;

thomasguillot · 2025-03-03T11:53:49Z

Assuming this is in reference to the Pattern & Template, yes they will only be registered on block themes.

Sorry, I was talking about the Blocks.

…g blocks

github-actions · 2025-03-04T10:03:17Z

Hey @Takshil-Kunadia, good job getting this PR merged! 🎉

Now, the needs-changelog label has been added to it.

Please check if this PR needs to be included in the "Upcoming Changes" and "Release Notes" doc. If it doesn't, simply remove the label.

If it does, please add an entry to our shared document, with screenshots and testing instructions if applicable, then remove the label.

Thank you! ❤️

# [6.1.0-alpha.1](v6.0.1...v6.1.0-alpha.1) (2025-03-06) ### Bug Fixes * **modal-checkout:** password setup ([8fbfabd](8fbfabd)) * **my-account:** handle email change esp sync errors ([#3792](#3792)) ([3d9f294](3d9f294)) * **my-account:** send change email to old and new emails ([#3786](#3786)) ([710d53d](710d53d)) * **premium-newsletters:** show premium lists in post-checkout signup ([#3788](#3788)) ([ccb1526](ccb1526)) * spacer block handling with registration block ([e9b7beb](e9b7beb)) ### Features * **correction-blocks:** Correction box & Loop item + Template ([#3787](#3787)) ([c215dc2](c215dc2)) * **correction-blocks:** update corrections template ([#3793](#3793)) ([c7aea33](c7aea33)) * **my-account:** add email change cancellation option ([#3778](#3778)) ([600ad61](600ad61)) * **my-account:** sync admin email change with ESP/stripe ([#3799](#3799)) ([7179ffd](7179ffd)) * **my-account:** sync email change with esp ([#3780](#3780)) ([983c087](983c087)) * **my-account:** sync email change with stripe ([#3789](#3789)) ([4f45795](4f45795))

matticbot · 2025-03-06T20:48:02Z

🎉 This PR is included in version 6.1.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

# [6.1.0](v6.0.5...v6.1.0) (2025-03-18) ### Bug Fixes * **modal-checkout:** endpoint to refresh newsletter lists via REST ([#3841](#3841)) ([2b294e0](2b294e0)) * **modal-checkout:** password setup ([8fbfabd](8fbfabd)) * **my-account:** handle email change esp sync errors ([#3792](#3792)) ([3d9f294](3d9f294)) * **my-account:** send change email to old and new emails ([#3786](#3786)) ([710d53d](710d53d)) * **premium-newsletters:** show premium lists in post-checkout signup ([#3788](#3788)) ([ccb1526](ccb1526)) * spacer block handling with registration block ([e9b7beb](e9b7beb)) ### Features * **correction-blocks:** Correction box & Loop item + Template ([#3787](#3787)) ([c215dc2](c215dc2)) * **correction-blocks:** update corrections template ([#3793](#3793)) ([c7aea33](c7aea33)) * enable email change for newspack users ([#3824](#3824)) ([9c152a8](9c152a8)) * **my-account:** add email change cancellation option ([#3778](#3778)) ([600ad61](600ad61)) * **my-account:** sync admin email change with ESP/stripe ([#3799](#3799)) ([7179ffd](7179ffd)) * **my-account:** sync email change with esp ([#3780](#3780)) ([983c087](983c087)) * **my-account:** sync email change with stripe ([#3789](#3789)) ([4f45795](4f45795)) * **woo-member-commenting:** optional module for member commenting ([#3783](#3783)) ([90746c8](90746c8)) ### Reverts * Revert "refactor(corrections): remove corrections feature flag (#3797)" (#3825) ([afd01f2](afd01f2)), closes [#3797](#3797) [#3825](#3825)

matticbot · 2025-03-18T18:23:10Z

🎉 This PR is included in version 6.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Takshil-Kunadia mentioned this pull request Feb 28, 2025

feat: Correction box & Loop item blocks Automattic/newspack-block-theme#312

Closed

6 tasks

Takshil-Kunadia added 4 commits February 28, 2025 13:37

feat(corrections-blocks): add Correction Box block

5f81b78

feat(corrections-blocks): add Correction Item block

034c13d

feat(corrections-blocks): register Corrections Loop block pattern

df3816b

feat(corrections-blocks): add Corrections archive block template

45ff164

Takshil-Kunadia force-pushed the feature/correction-blocks branch from a72c96a to 45ff164 Compare February 28, 2025 08:09

Takshil-Kunadia marked this pull request as ready for review February 28, 2025 10:52

Takshil-Kunadia requested a review from a team as a code owner February 28, 2025 10:53

Takshil-Kunadia requested review from leogermani and thomasguillot February 28, 2025 10:53

leogermani approved these changes Feb 28, 2025

View reviewed changes

github-actions Bot added the [Status] Approved The pull request has been reviewed and is ready to merge label Feb 28, 2025

thomasguillot requested changes Mar 3, 2025

View reviewed changes

thomasguillot added [Status] Needs Review The issue or pull request needs to be reviewed and removed [Status] Approved The pull request has been reviewed and is ready to merge labels Mar 3, 2025

thomasguillot requested a review from leogermani March 3, 2025 10:25

Takshil-Kunadia added 2 commits March 3, 2025 16:08

refactor(correction-blocks): remove timezone from correction heading

1849888

feat(corrections-blocks): add translation support for Corrections & C…

b5bec74

…larifications text

refactor(corrections-blocks): check for block theme before registerin…

31c3a1d

…g blocks

Takshil-Kunadia requested a review from thomasguillot March 4, 2025 05:48

thomasguillot approved these changes Mar 4, 2025

View reviewed changes

github-actions Bot added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels Mar 4, 2025

thomasguillot merged commit c215dc2 into trunk Mar 4, 2025

thomasguillot deleted the feature/correction-blocks branch March 4, 2025 10:03

github-actions Bot added the needs-changelog label Mar 4, 2025

leogermani removed the needs-changelog label Mar 5, 2025

matticbot added the released on @alpha label Mar 6, 2025

matticbot added the released label Mar 18, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(correction-blocks): Correction box & Loop item + Template#3787

feat(correction-blocks): Correction box & Loop item + Template#3787
thomasguillot merged 7 commits into
trunkfrom
feature/correction-blocks

Takshil-Kunadia commented Feb 28, 2025

Uh oh!

thomasguillot left a comment

Uh oh!

Takshil-Kunadia commented Mar 3, 2025

Uh oh!

thomasguillot commented Mar 3, 2025

Uh oh!

github-actions Bot commented Mar 4, 2025

Uh oh!

matticbot commented Mar 6, 2025

Uh oh!

matticbot commented Mar 18, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

Takshil-Kunadia commented Feb 28, 2025

All Submissions:

Changes proposed in this Pull Request:

How to test the changes in this Pull Request:

Testing Corrections Box Block:-

Testing Corrections Loop Block Pattern:-

Testing Corrections Archive Block Template:-

For individual testing of the Corrections Loop item block

Other information:

Uh oh!

thomasguillot left a comment

Choose a reason for hiding this comment

Uh oh!

Takshil-Kunadia commented Mar 3, 2025

Uh oh!

thomasguillot commented Mar 3, 2025

Uh oh!

github-actions Bot commented Mar 4, 2025

Uh oh!

matticbot commented Mar 6, 2025

Uh oh!

matticbot commented Mar 18, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants