feat(content-loop): support custom bylines#2105
Conversation
leogermani
left a comment
There was a problem hiding this comment.
When using the custom byline, the post date sticks together with the last author name
In this branch, the Carousel block throws an error.
Question: Looking at the code I wonder if we should offer a filter, instead of calling the Bylines method directly... something like we did in the theme -> https://github.com/Automattic/newspack-theme/blob/trunk/newspack-theme/inc/template-tags.php#L92
|
I got into a bit of a rabbit hole looking into implementing filters and decided to refactor how the editor renders the avatars and bylines. Filters weren't practical before this refactor because the editor doesn't use the markup used in the view. It should now be unified and filterable, which is simpler and better to maintain. |
|
Hey @miguelpeixe, good job getting this PR merged! 🎉 Now, the Please check if this PR needs to be included in the "Upcoming Changes" and "Release Notes" doc. If it doesn't, simply remove the label. If it does, please add an entry to our shared document, with screenshots and testing instructions if applicable, then remove the label. Thank you! ❤️ |
# [4.11.0-alpha.1](v4.10.1...v4.11.0-alpha.1) (2025-04-23) ### Bug Fixes * adjust cache handling for feeds ([#2112](#2112)) ([f880061](f880061)) * update how we check for the express checkout in the is_modal check ([#2109](#2109)) ([652daf7](652daf7)) ### Features * add body class depending on theme type ([#2101](#2101)) ([efcda76](efcda76)) * **content-loop:** support custom bylines ([#2105](#2105)) ([6f70449](6f70449)) * **wcsg:** respect checkbox label option in WCSG settings ([#2053](#2053)) ([58e40c5](58e40c5))
|
🎉 This PR is included in version 4.11.0-alpha.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
# [4.12.0-alpha.1](v4.11.0...v4.12.0-alpha.1) (2025-05-08) ### Bug Fixes * adjust cache handling for feeds ([#2112](#2112)) ([f880061](f880061)) * update how we check for the express checkout in the is_modal check ([#2109](#2109)) ([652daf7](652daf7)) ### Features * add body class depending on theme type ([#2101](#2101)) ([efcda76](efcda76)) * **content-loop:** support custom bylines ([#2105](#2105)) ([6f70449](6f70449)) * **wcsg:** respect checkbox label option in WCSG settings ([#2053](#2053)) ([58e40c5](58e40c5))
|
🎉 This PR is included in version 4.12.0-alpha.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
# [4.12.0](v4.11.0...v4.12.0) (2025-05-14) ### Bug Fixes * adjust cache handling for feeds ([#2112](#2112)) ([f880061](f880061)) * update how we check for the express checkout in the is_modal check ([#2109](#2109)) ([652daf7](652daf7)) ### Features * add body class depending on theme type ([#2101](#2101)) ([efcda76](efcda76)) * **content-loop:** support custom bylines ([#2105](#2105)) ([6f70449](6f70449)) * **wcsg:** respect checkbox label option in WCSG settings ([#2053](#2053)) ([58e40c5](58e40c5))
|
🎉 This PR is included in version 4.12.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
All Submissions:
Changes proposed in this Pull Request:
Implement custom byline support to the Content Loop block.
This PR also refactors how avatars and bylines are rendered in the editor for the Content Loop and Carousel blocks. It unifies the rendering strategy, passing the full markup instead of author data for react parsing. The single strategy improves extensibility and maintainability.
Supersedes #2091
How to test the changes in this Pull Request:
Other information: