WooCommerce Services JITM: use redirect parameter.#9239
Merged
dereksmart merged 1 commit intomasterfrom Apr 24, 2018
Merged
Conversation
… referer. Relying on referer alone fails in browsers that strip those headers for DNT purposes.
kbrown9
added a commit
that referenced
this pull request
Oct 14, 2019
In PR #9239, wp_get_referer() was described as unrealiable because some browsers strip the 'referer' header. So let's just use admin_url() as the fallback redirect URL if $_GET['redirect'] is empty.
kraftbj
pushed a commit
that referenced
this pull request
Oct 16, 2019
In PR #9239, wp_get_referer() was described as unrealiable because some browsers strip the 'referer' header. So let's just use admin_url() as the fallback redirect URL if $_GET['redirect'] is empty.
jeherve
added a commit
that referenced
this pull request
Oct 17, 2019
* WooCommerce Services: Use home_url to create redirect url The redirect URL is created using the value of $_SERVER['REQUEST_URI'], which includes 'wp-admin/'. When admin_url() is used to create the redirect URL, the resulting URL is incorrect. Use home_url() instead. Also properly unslash and sanitize $_GET['redirect']. * WooCommerce Services: Use admin_url as the fallback URL In PR #9239, wp_get_referer() was described as unrealiable because some browsers strip the 'referer' header. So let's just use admin_url() as the fallback redirect URL if $_GET['redirect'] is empty. * WooCommerce Services: Fix PHPCS errors and warnings. * Fix last PHPCS warning and add file to whitelist. Co-authored-by: Jeremy Herve <jeremy@jeremy.hu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
redirectJITM parameter, only using HTTP referer as a fallback.Relying on referer alone fails in browsers that strip those headers for DNT purposes.
Testing instructions:
Proposed changelog entry for your changes: