Skip to content

Don't show upsells for SEO and Google Analytics for Premium Plans#8745

Merged
mattwiebe merged 1 commit intomasterfrom
fix/premium-features
Feb 5, 2018
Merged

Don't show upsells for SEO and Google Analytics for Premium Plans#8745
mattwiebe merged 1 commit intomasterfrom
fix/premium-features

Conversation

@mattwiebe
Copy link
Copy Markdown
Contributor

The work started in #8584 did not address the upsells/setting links in the SEO Tools and Google Analytics cards for Premium Plans.

Testing instructions:

Load Jetpack's settings page in wp-admin for a site with a Premium plan, go to the Traffic section. Without this branch, you will see:

seo-ga

With this branch, you should see:

screen shot 2018-02-02 at 12 35 34

The work started in #8584 did not address the upsells/setting links in the SEO Tools and Google Analytics cards for Premium Plans.
@mattwiebe mattwiebe added [Status] Needs Review This PR is ready for review. Admin Page React-powered dashboard under the Jetpack menu [Feature] SEO Tools Tools for improving a site's search engine optimization. [Feature] Google Analytics labels Feb 2, 2018
@mattwiebe mattwiebe requested a review from a team as a code owner February 2, 2018 18:37
@mattwiebe mattwiebe requested review from bubel and zinigor February 2, 2018 18:37
@jeherve jeherve added this to the 5.8 milestone Feb 3, 2018
Copy link
Copy Markdown
Contributor

@oskosk oskosk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@oskosk oskosk added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Feb 5, 2018
@mattwiebe mattwiebe merged commit 4492dab into master Feb 5, 2018
@mattwiebe mattwiebe deleted the fix/premium-features branch February 5, 2018 16:52
@matticbot matticbot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Feb 5, 2018
zinigor pushed a commit that referenced this pull request Feb 5, 2018
The work started in #8584 did not address the upsells/setting links in the SEO Tools and Google Analytics cards for Premium Plans.
@zinigor
Copy link
Copy Markdown
Contributor

zinigor commented Feb 5, 2018

Ported to `branch-5.8' in 779ff75.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Admin Page React-powered dashboard under the Jetpack menu [Feature] Google Analytics [Feature] SEO Tools Tools for improving a site's search engine optimization. Plans [Pri] High

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants