Skip to content

Better checks for active Jetpack in Tracks#8685

Merged
jeherve merged 1 commit intomasterfrom
fix/stop-tracks-at-source
Jan 31, 2018
Merged

Better checks for active Jetpack in Tracks#8685
jeherve merged 1 commit intomasterfrom
fix/stop-tracks-at-source

Conversation

@dereksmart
Copy link
Copy Markdown
Contributor

Blocks sending a tracks event (if Jetpack is not connected) late enough to catch all instances of sending an event.

@dereksmart dereksmart requested a review from a team as a code owner January 31, 2018 15:01
@dereksmart dereksmart added this to the 5.8 milestone Jan 31, 2018
Copy link
Copy Markdown
Contributor

@oskosk oskosk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@oskosk oskosk added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Jan 31, 2018
Copy link
Copy Markdown
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Merging.

@jeherve jeherve merged commit 4ce9794 into master Jan 31, 2018
@jeherve jeherve deleted the fix/stop-tracks-at-source branch January 31, 2018 18:15
@jeherve jeherve removed the [Status] Ready to Merge Go ahead, you can push that green button! label Jan 31, 2018
jeherve pushed a commit that referenced this pull request Jan 31, 2018
@jeherve
Copy link
Copy Markdown
Member

jeherve commented Jan 31, 2018

Cherry-picked to branch-5.8 in db1e5f7

@oskosk
Copy link
Copy Markdown
Contributor

oskosk commented Feb 20, 2018

I'm inclined to revert this one and then see how to fix again. What do you think @dereksmart ?

@dereksmart
Copy link
Copy Markdown
Contributor Author

@oskosk yeah, I'd like to try and find a solution where we rely instead on whether or not they have agreed to the TOS / clicked the connect button at least once.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants