JPO: Remove sanitize key on registration URL#8501
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seems like in #8449 we introduced
sanitize_keyover the registration URL onboarding token. This was a mistake, because it caused (only) fresh Jetpack sites onboarding tokens to be passed to Calypso as lowercase instead of uppercase 🤦♂️ And then, when comparing the lowercase tokens to the original ones, comparison failed and signature was different, thus we received the "The request is not signed correctly." error.So, we don't need the
sanitize_keyand we can remove it safely.To test:
Kudos to @oskosk for finding this issue, and for helping diagnose it.