JPC: Support onboarding in register step#8449
Merged
Conversation
ockham
approved these changes
Jan 3, 2018
Contributor
ockham
left a comment
There was a problem hiding this comment.
Can repro both the issue, and the fix 👍
Member
Author
|
@oskosk when you get the chance to review and test it, feel free to merge it directly if it looks good to you. Thank you all! 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As @oskosk correctly identified and explained in #8414 (comment), with a fresh JP site we're unable to initiate the onboarding process. This is because in the initial JPC registration step, we didn't support the onboarding parameter when isolating JPO logic in #8414.
To test: