Skip to content

Hide all mentions of VaultPress if rewind is available but not active#8392

Merged
dereksmart merged 2 commits intomasterfrom
update/hide-all-mention-of-vp-if-rewind-available
Dec 20, 2017
Merged

Hide all mentions of VaultPress if rewind is available but not active#8392
dereksmart merged 2 commits intomasterfrom
update/hide-all-mention-of-vp-if-rewind-available

Conversation

@dereksmart
Copy link
Copy Markdown
Contributor

@dereksmart dereksmart commented Dec 20, 2017

If Rewind is not active, but available for some reason, hide all mentions of VaultPress.

Test:

  • If a site is unavailable for Rewind, everything should behave as normal
  • If a site has rewind active, continue to show mentions/cards for rewind
  • If a site is not either of those, i.e. "available", then you should not see any cards for VaultPress in neither /plans, nor /settings/, nor /dashboard.

@dereksmart dereksmart added Admin Page React-powered dashboard under the Jetpack menu [Status] Needs Review This PR is ready for review. labels Dec 20, 2017
@dereksmart dereksmart requested a review from a team as a code owner December 20, 2017 06:24
@oskosk oskosk added this to the 5.7 milestone Dec 20, 2017
@oskosk oskosk changed the title Hide all mentions of VaultPress is rewind is available but not active Hide all mentions of VaultPress if rewind is available but not active Dec 20, 2017
@eliorivero
Copy link
Copy Markdown
Contributor

eliorivero commented Dec 20, 2017

Works great 🐑

@eliorivero eliorivero added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Dec 20, 2017
@samhotchkiss
Copy link
Copy Markdown
Contributor

samhotchkiss commented Dec 20, 2017 •
edited
Loading

@dereksmart dereksmart merged commit 0cc673c into master Dec 20, 2017
@dereksmart dereksmart deleted the update/hide-all-mention-of-vp-if-rewind-available branch December 20, 2017 17:01
@dereksmart dereksmart modified the milestones: 5.7, vp-rewind-pressable Dec 20, 2017
dereksmart added a commit that referenced this pull request Dec 20, 2017
@dereksmart
Hide all mentions of VaultPress if rewind is available but not active (…
ab40abd 
…#8392)

* Hide all mentions of VaultPress is rewind is available but not active

* removed commented code
@oskosk oskosk modified the milestones: vp-rewind-pressable, 5.7 Dec 22, 2017
@kraftbj kraftbj removed the [Status] Ready to Merge Go ahead, you can push that green button! label Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@eliorivero eliorivero eliorivero approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Admin Page React-powered dashboard under the Jetpack menu [Feature] Activity Log

Projects

None yet

Milestone

5.7

Development

Successfully merging this pull request may close these issues.

5 participants

@dereksmart @eliorivero @samhotchkiss @kraftbj @oskosk