Plugin API: Installing plugins always returns an error.#8017
Merged
Conversation
Recently we added some bug fixes. This introduced a bug where we would always be returning an error when we install an plugin. This PR fixes this by making sure that $error is being checked for the empty case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recently we added some bug fixes. This introduced a bug where we would always be returning an error when we install an plugin.
This PR fixes this by making sure that $error is being checked for the empty case.
Changes proposed in this Pull Request:
Testing instructions:
Run this PR Go to calypso and install a plugin. Notice that this doesn't error.
Proposed changelog entry for your changes: