Mailchimp: save a shortcode when pasting a form code in the widget#7991
Merged
zinigor merged 1 commit intofix/mailchimp-shortcode-7945from Oct 18, 2017
Merged
Conversation
Fixes #7960 Fixes #7990 - The widget now calls the shortcode file even when the shortcodes are not active, so you do not need to activate the shortcode module for this to work. - On save, the widget uses the reversal function provided in the shortcode to save a valid shortcode. - That shortcode is then displayed in the widget, as before.
zinigor
added a commit
that referenced
this pull request
Oct 19, 2017
This is needed since #7991 has landed in Jetpack. There is a particular edge case that illustrates the problem. After #7991 the widget would check if a shortcode is present, and would load it if it wasn't. If then the shortcode would try to include that file again, it would fatal. This could happen when you have the widgets module enabled, and shortcode modules disabled. The fatal would appear in the request when you're trying to enable the shortcodes module.
oskosk
pushed a commit
that referenced
this pull request
Oct 19, 2017
This is needed since #7991 has landed in Jetpack. There is a particular edge case that illustrates the problem. After #7991 the widget would check if a shortcode is present, and would load it if it wasn't. If then the shortcode would try to include that file again, it would fatal. This could happen when you have the widgets module enabled, and shortcode modules disabled. The fatal would appear in the request when you're trying to enable the shortcodes module.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important: this PR is set to be merged into the
fix/mailchimp-shortcode-7945branch, since the widget is broken right now and this PR couldn't be tested without the changes included in #7989Fixes #7960
Fixes #7990
Testing instructions:
https://en.support.wordpress.com/mailchimp/
Repeat those steps when the Shortcodes module is deactivated; nothing should change.
Proposed changelog entry for your changes: