Skip to content

Settings UI: align and space elements#6664

Merged
eliorivero merged 7 commits intofeature/settings-overhaulfrom
update/styles-align
Mar 16, 2017
Merged

Settings UI: align and space elements#6664
eliorivero merged 7 commits intofeature/settings-overhaulfrom
update/styles-align

Conversation

@eliorivero
Copy link
Copy Markdown
Contributor

@eliorivero eliorivero commented Mar 15, 2017

Changes proposed in this Pull Request:

fixes #6554

  • align learn more icons, mobile and desktop

    captura de pantalla 2017-03-15 a las 12 04 03 captura de pantalla 2017-03-15 a las 11 25 47
  • evenly space toggle explanation
    Before

    captura de pantalla 2017-03-15 a las 12 25 19 captura de pantalla 2017-03-15 a las 12 44 31

    After

    captura de pantalla 2017-03-15 a las 12 25 40 captura de pantalla 2017-03-15 a las 12 44 16
  • vertically align text with toggle
    Before
    captura de pantalla 2017-03-15 a las 12 37 25
    captura de pantalla 2017-03-15 a las 12 40 55

    After
    captura de pantalla 2017-03-15 a las 12 37 43
    captura de pantalla 2017-03-15 a las 12 41 06

  • align toggles and notice in dash items, also solves bad positioning issue for notice in dash item on mobile

captura de pantalla 2017-03-15 a las 16 57 51

captura de pantalla 2017-03-15 a las 17 01 34

captura de pantalla 2017-03-15 a las 17 01 50

  • indent explanation for Photon toggle
    captura de pantalla 2017-03-15 a las 18 10 24

  • update texts for Protect settings card, "Brute force login blocking" for header and "Block suspicious-looking login activity" for toggle description

@eliorivero eliorivero added Admin Page React-powered dashboard under the Jetpack menu Enhancement Changes to an existing feature — removing, adding, or changing parts of it labels Mar 15, 2017
@eliorivero eliorivero added this to the Settings UI milestone Mar 15, 2017
@eliorivero eliorivero self-assigned this Mar 15, 2017
@eliorivero eliorivero force-pushed the update/styles-align branch from 2925a35 to 3bf9d46 Compare March 15, 2017 15:26
@eliorivero eliorivero force-pushed the update/styles-align branch from ad3c0a3 to 8d7222a Compare March 15, 2017 20:18
@eliorivero eliorivero added [Status] Needs Review This PR is ready for review. and removed [Status] In Progress labels Mar 15, 2017
@eliorivero eliorivero force-pushed the update/styles-align branch from 410ae7f to 7fc20c2 Compare March 15, 2017 21:25
@MichaelArestad
Copy link
Copy Markdown
Contributor

It looks like the infoPopover has inconsistent spacing in the foldable cards:

image

image

image

Other than that, this PR is golden.

@MichaelArestad
Copy link
Copy Markdown
Contributor

MichaelArestad commented Mar 15, 2017

The only other thing left to align is the Banner button and I think I can swing that pretty quickly.

PR: Automattic/dops-components#101

@eliorivero
Copy link
Copy Markdown
Contributor Author

  • Updated spacing and alignment of info icon inside foldable card

Before

captura de pantalla 2017-03-16 a las 10 25 07

After

captura de pantalla 2017-03-16 a las 11 16 17

  • Aligned elements on mobile

captura de pantalla 2017-03-16 a las 11 16 31

  • Fixed line height for foldable card header

Before

captura de pantalla 2017-03-16 a las 11 17 31

After

captura de pantalla 2017-03-16 a las 11 19 13

@MichaelArestad
Copy link
Copy Markdown
Contributor

LGTM

@MichaelArestad MichaelArestad added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Mar 16, 2017
@eliorivero eliorivero force-pushed the update/styles-align branch from 769fa54 to 134a1f0 Compare March 16, 2017 21:46
@eliorivero eliorivero merged commit 7202fb8 into feature/settings-overhaul Mar 16, 2017
@eliorivero eliorivero deleted the update/styles-align branch March 16, 2017 21:47
@eliorivero eliorivero removed the [Status] Ready to Merge Go ahead, you can push that green button! label Mar 16, 2017
georgestephanis pushed a commit that referenced this pull request Mar 22, 2017
…ar fallback image size of 200 pixels square.

FIxes #6664.

Merges r148090-wpcom.
samhotchkiss pushed a commit that referenced this pull request Mar 28, 2017
* Widgets: Facebook Like Box: Fallback to WordPress locale or English for unknown locale

See: r117058
See: https://[private link]

Merges r120105-wpcom.

* Facebook Like Box Widget: Restore 'width' option to support widget areas wider than 340px.

We recently removed the width option from this widget in order to allow it to be responsive. However, it defaults to 340px at largest, which is a problem for wider widget areas.

This is a partial revert of r119494-wpcom.

https://[private link]
ed2c2a9
https://[private link]#comment-33575

Merges r121114-wpcom.

* Widgets: Facebook Page Plugin: Update the wp-admin strings for "Like Box" to read "Page Plugin" instead, since the code now loads the Facebook page plugin code instead.

Merges r123111-wpcom.

* Widgets: rename `widget` pageview stat to something more useful: `widget_view`, see #7805.

Merges r144861-wpcom.

* Widgets: minor code and comments cleanup in Facebook Page Plugin.

See #6421.

Merges r148069-wpcom.

* Widgets: Facebook Page Plugin: better UX for min/max height and width values.

Fixes https://github.com/Automattic/customization/issues/53

Merges r148071-wpcom.

* Widgets: more attribute escaping for Facebook Page Plugin widget.

See r148071.

Merges r148072-wpcom.

* Widgets: add pageview tracking to more active WP.com widgets, see #7805.

Merges r144867-wpcom.

* Widgets: minor documentation fixes, code style for Google Translate widget.

See #7805

Merges r145017-wpcom.

* Widgets: rename `widget` pageview stat to something more useful: `widget_view`, see #7805.

Merges r144861-wpcom.

* Widgets: sync stats bumps with latest Jetpack changes.

See #5488

Merges r144995-wpcom.

* Widgets: add pageview tracking to more active WP.com widgets, see #7805.

Merges r144867-wpcom.

* Widgets: fix a few Jetpack stats bumps, see #7805.

Ref: #5488

Merges r144925-wpcom.

* Widgets: sync stats bumps with latest Jetpack changes.

See #5488

Merges r144995-wpcom.

* Widgets: minor documentation fixes, code style for Google Translate widget.

See #7805

Merges r145017-wpcom.

* Widgets: add Flickr to the services available in the Social Media Icons widget.

See #5156

Merges r148065-wpcom.

* Widgets: add pageview tracking to more active WP.com widgets, see #7805.

Merges r144867-wpcom.

* Widgets: sync stats bumps with latest Jetpack changes.

See #5488

Merges r144995-wpcom.

* Widgets: fix grid layout for Top Posts and Pages to show correct avatar fallback image size of 200 pixels square.

FIxes #6664.

Merges r148090-wpcom.

* Widgets: Update URL to create a Twitter widget

This is just a stopgap until we can fully integrate with the new
publish.twitter.com setup.  See https://github.com/Automattic/io/issues/601 for
more info.

Merges r137075-wpcom.

* Widgets: Update Twitter Timeline to not require a widget ID

https://[private link]

Merges r137600-wpcom.

* Widgets: Twitter Timeline: Use data-width= instead of width=

Same for height, and a couple of other cleanups.  See:

#3283

Merges r137659-wpcom.

* Widgets: Twitter Timeline: Fix a PHP notice

From review at #4198

Merges r137943-wpcom.

* Widgets: rename `widget` pageview stat to something more useful: `widget_view`, see #7805.

Merges r144861-wpcom.

* Widgets: fix a few Jetpack stats bumps, see #7805.

Ref: #5488

Merges r144925-wpcom.

* Widgets: sync stats bumps with latest Jetpack changes.

See #5488

Merges r144995-wpcom.

* Widgets: fix Twitter Timeline height (not used any more) and set maximum number of tweets to 20.

Fixes https://github.com/Automattic/customization/issues/74

Merges r148193-wpcom.

* Widgets: still honor Twitter Timeline 'height' value if it was previously set.

See r148193 and https://github.com/Automattic/customization/issues/74

However, Twitter might not honor it.

Merges r148239-wpcom.

* Widgets: revert the height changes to Twitter Timeline in r148193.

Needs more investigation on why they are ignored by Twitter's embed.

See https://github.com/Automattic/customization/issues/74

Merges r148240-wpcom.

* Widgets: further improvements to Twitter Timeline tweet limit and height values.

Per recommendations by Niall Kennedy: #6021 (comment)

 * When a valid tweet limit is set, ignore the user given height.
 * Properly validate the integer value of tweet limit.

See r148240 and https://github.com/Automattic/customization/issues/74

Merges r148835-wpcom.

* Apply timezone offsets to the upcomingevents shortcode

This patch adds changes to the calendar shortcode so that it applies a users timezone to all of the rendered events

See https://[private link]
Differential Revision: https://[private link]

Merges r151822-wpcom.

* Apply timezone offsets to the upcomingevents shortcode

This patch adds changes to the calendar shortcode so that it applies a users timezone to all of the rendered events

See https://[private link]
Differential Revision: https://[private link]

Merges r151822-wpcom.

* Fix calendar reader timezone offsets

This revision aims at fixing an issue in the `iCalendarReader` class
The function that applies timezone offsets calculates the time difference for timezones using the current date instead of the date thats actually associated with the event. This leads to Daylight Savings Time confusions if today is standard time and the event occurs in daylight savings time. Today (3-8-2017) an event for 3-15-2017 6:30pm will show up as 3-15-2017 5:30pm

For effected users see:
  - https://[private link]
  - https://[private link]
  - https://[private link]

Merges r152463-wpcom.

* Remove duplicated method.

Must have been a merge gone bad.
oskosk pushed a commit that referenced this pull request Apr 19, 2018
…ar fallback image size of 200 pixels square.

FIxes #6664.

Merges r148090-wpcom.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Admin Page React-powered dashboard under the Jetpack menu Enhancement Changes to an existing feature — removing, adding, or changing parts of it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants