Add in the ability to get thumbnails for VideoPress via media endpoint.#6631
Add in the ability to get thumbnails for VideoPress via media endpoint.#6631
Conversation
jeherve
left a comment
There was a problem hiding this comment.
I left 2 minor comments, but other than that it appears to work properly:
| // Switch to photon if needed. | ||
| $poster = str_replace( | ||
| 'https://videos.files.wordpress.com', | ||
| 'https://i0.wp.com/videos.files.wordpress.com', |
There was a problem hiding this comment.
Should we use apply_filters( 'jetpack_photon_url, $poster )` here, so all Photon filters / domain sharding / etc can be applied if needed?
There was a problem hiding this comment.
Makes sense, I'll apply this change and test. I was really just trying to fix the fact that Calypso won't work without Photon URLs here. But it makes sense to use the internal methods for this.
| // Switch to photon if needed. | ||
| $poster = str_replace( | ||
| 'https://videos.files.wordpress.com', | ||
| 'https://i0.wp.com/videos.files.wordpress.com', |
There was a problem hiding this comment.
Should we use the jetpack_photon_url filter here as well?
|
@jeherve I've made the requested changes and with a couple tiny gotchas, it seems to be working fine now. |
jeherve
left a comment
There was a problem hiding this comment.
This looks good and works in my tests! LGTM!
…t. (#6631) * Add in the ability to get thumbnails for VideoPress via media endpoint. * Switch to use photon filter.
|
merged to 4.7 ebcd7c1 |
When we pushed out VideoPress, it was missing poster thumbnails. This is needed to make Calypso work correctly with Jetpack sites.
This PR seeks to add thumbnails by adding the wpcom functions that the API tries to call, to add in the images.
Request: Can we get this in the next point release for Jetpack, to make sure we get Calypso working ASAP?
Testing
Simply check the media library in Calypso and make sure thumbnails are loading.
If checking the output for the media API for a Jetpack site, you should see the thumbnails reporting in there like this: