Conversation
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! Mu Wpcom plugin:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. Wpcomsh plugin:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
projects/packages/jetpack-mu-wpcom/src/features/gutenberg-rtc/gutenberg-rtc.php
Show resolved
Hide resolved
Code Coverage SummaryCoverage changed in 1 file.
2 files are newly checked for coverage.
Full summary · PHP report · JS report Coverage check overridden by
I don't care about code coverage for this PR
|
|
Works as expected on Simple sites. I'll continue testing on WoW sites. |
…7664) - Extracts the Real-time Collaboration (RTC) implementation from `jetpack-mu-wpcom` into a standalone `automattic/jetpack-rtc` package - The new package provides PingHub WebSocket transport for Gutenberg's RTC feature, including the PHP class (`Automattic\Jetpack\RTC`), REST API endpoint for PingHub JWT tokens, and the JS provider registration - `jetpack-mu-wpcom` now only hooks into `jetpack_rtc_enabled` to enable/disable RTC based on the `WPCOM_Features::REAL_TIME_COLLABORATION` feature flag, delegating all logic to the new package - In a follow-up PR, we'll create a new Jetpack module for self-hosted sites so they can get the WebSocket transport too.
Fixes DOTCOM-16392
Proposed changes
jetpack-mu-wpcominto a standaloneautomattic/jetpack-rtcpackageAutomattic\Jetpack\RTC), REST API endpoint for PingHub JWT tokens, and the JS providerregistration
jetpack-mu-wpcomnow only hooks intojetpack_rtc_enabledto enable/disable RTC based on theWPCOM_Features::REAL_TIME_COLLABORATIONfeature flag, delegating all logic to the new packageRelated product discussion/links
p58i-pRN-p2
Does this pull request change what data or activity we track or use?
No
Testing instructions
wpcom-features-edgestickerwp-admin/options-writing.phpon the sandboxed sitewpcom-features-edgestickersync/updatesendpointadd_filter( 'jetpack_rtc_providers', function() { return array( 'http-polling' ); }, 100 );sync/updatesendpointwpcom-features-edgestickerwp-admin/options-writing.phpwpcom-features-edgestickersync/updatesendpointadd_filter( 'jetpack_rtc_providers', function() { return array( 'http-polling' ); }, 100 );sync/updatesendpoint