Skip to content

Revert "Forms: Use JWT for passing the Contact_Form object around"#44397

Merged
enejb merged 1 commit intotrunkfrom
revert-44360-update/add-jwt-form-encode-decode
Jul 21, 2025
Merged

Revert "Forms: Use JWT for passing the Contact_Form object around"#44397
enejb merged 1 commit intotrunkfrom
revert-44360-update/add-jwt-form-encode-decode

Conversation

@enejb
Copy link
Copy Markdown
Member

@enejb enejb commented Jul 21, 2025

Reverts #44360

Due to some Fatal Errors in shortcodes.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 21, 2025

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the revert-44360-update/add-jwt-form-encode-decode branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack revert-44360-update/add-jwt-form-encode-decode

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions github-actions bot added [Feature] Forms [Package] Forms [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Tests] Includes Tests [Type] Revert labels Jul 21, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 21, 2025

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • 🔴 Include a description of your PR changes.
  • 🔴 Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • 🔴 Add testing instructions.
  • 🔴 Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


🔴 Action required: Please edit your PR description and explain what functional changes your PR includes, and why those changes are needed.


🔴 Action required: Please include detailed testing steps, explaining how to test your change, like so:

## Testing instructions:

* Go to '..'
*

🔴 Action required: We would recommend that you add a section to the PR description to specify whether this PR includes any changes to data or privacy, like so:

## Does this pull request change what data or activity we track or use?

My PR adds *x* and *y*.

Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!


Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

  • WordPress.com Simple releases happen as soon as you deploy your changes after merging this PR (PCYsg-Jjm-p2).
  • WoA releases happen weekly.
  • Releases to self-hosted sites happen monthly:
    • Scheduled release: August 5, 2025
    • Code freeze: August 4, 2025

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@github-actions github-actions bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Jul 21, 2025
@jp-launch-control
Copy link
Copy Markdown

Code Coverage Summary

Coverage changed in 2 files.

File Coverage Δ% Δ Uncovered
projects/packages/forms/src/contact-form/class-contact-form-plugin.php 424/1180 (35.93%) -1.96% 20 💔
projects/packages/forms/src/contact-form/class-contact-form.php 600/1101 (54.50%) -0.72% -1 💚

Full summary · PHP report · JS report

If appropriate, add one of these labels to override the failing coverage check: Covered by non-unit tests Use to ignore the Code coverage requirement check when E2Es or other non-unit tests cover the code Coverage tests to be added later Use to ignore the Code coverage requirement check when tests will be added in a follow-up PR I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage.

@enejb enejb merged commit 4f2e72b into trunk Jul 21, 2025
68 of 69 checks passed
@enejb enejb deleted the revert-44360-update/add-jwt-form-encode-decode branch July 21, 2025 15:40
@github-actions github-actions bot removed the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Jul 21, 2025
@github-actions github-actions bot added this to the jetpack/14.9 milestone Jul 21, 2025
tbradsha pushed a commit that referenced this pull request Jul 21, 2025
tbradsha added a commit that referenced this pull request Jul 21, 2025
* Changelog and readme.txt edits.

* Release packages that depend on status package

* Revert "Forms: Use JWT for passing the Contact_Form object around (#44360)" (#44397)

This reverts commit fa03729.

* Release packages/forms 4.0.1

* Version bumps

---------

Co-authored-by: Enej Bajgoric <enej.bajgoric@automattic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Feature] Forms [Package] Forms [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Tests] Includes Tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant