i18n: Revert use of number-formatters for currency-formatting in donations block#43405
Conversation
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! Jetpack plugin: No scheduled milestone found for this plugin. If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
Code Coverage SummaryThis PR did not change code coverage! That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷 |
jeherve
left a comment
There was a problem hiding this comment.
I think you'll also need to update projects/plugins/jetpack/tools/check-block-assets.php again:
Block view script dependency check detected issues!
In projects/plugins/jetpack/tools/check-block-assets.php
Allowlist data for the donations block lists unneeded dependencies: wp-date.
Dependencies allowed may be adjusted by editing the arrays at the top of projects/plugins/jetpack/tools/check-block-assets.php.
Yep. Done. |
jeherve
left a comment
There was a problem hiding this comment.
This tests well and fixes the issue. 🚢
coder-karen
left a comment
There was a problem hiding this comment.
Tests well for me too 🚢
|
Thanks! |
Fixes #43401
Proposed changes:
@automattic/format-currencyv1 package that was previously used for formatting currencies in the donations block. TheformatCurrencymethod from@automattic/format-currencypackage was recently refactored with@automatic/number-formatterspackage in i18n: UpdateformatCurrency/getCurrencyObjectimports to be from@automattic/number-formatters#42796Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions: