Skip to content

i18n: Revert use of number-formatters for currency-formatting in donations block#43405

Merged
chriskmnds merged 3 commits intotrunkfrom
update/i18n-number-formatters-donations-bring-format-currency-back
May 8, 2025
Merged

i18n: Revert use of number-formatters for currency-formatting in donations block#43405
chriskmnds merged 3 commits intotrunkfrom
update/i18n-number-formatters-donations-bring-format-currency-back

Conversation

@chriskmnds
Copy link
Copy Markdown
Contributor

@chriskmnds chriskmnds commented May 8, 2025

Fixes #43401

Proposed changes:

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Check out this PR. Have the JP development env ready and working (or however else you more easily test JP commits)
  • Open a post and add the donations block (needs a Stripe connection)
  • Confirm the issue no longer exists

@chriskmnds chriskmnds self-assigned this May 8, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 8, 2025

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the update/i18n-number-formatters-donations-bring-format-currency-back branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack update/i18n-number-formatters-donations-bring-format-currency-back

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions github-actions bot added [Block] Donations [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Type] Revert labels May 8, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 8, 2025

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!


Jetpack plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@github-actions github-actions bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label May 8, 2025
@chriskmnds chriskmnds requested review from a team and jeherve May 8, 2025 09:46
@jp-launch-control
Copy link
Copy Markdown

jp-launch-control bot commented May 8, 2025

Code Coverage Summary

This PR did not change code coverage!

That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷

Full summary · PHP report · JS report

Copy link
Copy Markdown
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you'll also need to update projects/plugins/jetpack/tools/check-block-assets.php again:

Block view script dependency check detected issues!

In projects/plugins/jetpack/tools/check-block-assets.php
Allowlist data for the donations block lists unneeded dependencies: wp-date.

Dependencies allowed may be adjusted by editing the arrays at the top of projects/plugins/jetpack/tools/check-block-assets.php.

@chriskmnds
Copy link
Copy Markdown
Contributor Author

I think you'll also need to update projects/plugins/jetpack/tools/check-block-assets.php again:

Block view script dependency check detected issues!

In projects/plugins/jetpack/tools/check-block-assets.php
Allowlist data for the donations block lists unneeded dependencies: wp-date.

Dependencies allowed may be adjusted by editing the arrays at the top of projects/plugins/jetpack/tools/check-block-assets.php.

Yep. Done.

@chriskmnds chriskmnds requested a review from jeherve May 8, 2025 09:59
Copy link
Copy Markdown
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This tests well and fixes the issue. 🚢

@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. labels May 8, 2025
Copy link
Copy Markdown
Contributor

@coder-karen coder-karen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests well for me too 🚢

@chriskmnds chriskmnds merged commit 8e1699e into trunk May 8, 2025
68 checks passed
@chriskmnds chriskmnds deleted the update/i18n-number-formatters-donations-bring-format-currency-back branch May 8, 2025 11:01
@chriskmnds
Copy link
Copy Markdown
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Block] Donations [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Donations Form: Unable to edit defaults, currency symbol appears twice

3 participants