Skip to content

i18n: Internalise legacy CURRENCIES object from @automattic/format-currency#42457

Closed
chriskmnds wants to merge 7 commits intotrunkfrom
update/i18n-internalize-currencies-object
Closed

i18n: Internalise legacy CURRENCIES object from @automattic/format-currency#42457
chriskmnds wants to merge 7 commits intotrunkfrom
update/i18n-internalize-currencies-object

Conversation

@chriskmnds
Copy link
Copy Markdown
Contributor

@chriskmnds chriskmnds commented Mar 14, 2025 •
edited
Loading

Part of a PT: pxLjZ-9ME-p2
Partly addresses https://github.com/Automattic/i18n-issues/issues/939 and https://github.com/Automattic/i18n-issues/issues/942
Based off #42456

Proposed changes:

Before we can consolidate number and currency formatting in Jetpack we need to bring @automattic/format-currency to the latest version (2.0.0). We internalise some of the legacy functionality that's no longer present in format-currency so we upgrade.

Fixing these cases (to remove the legacy code completely) can be done separately by folks more familiar with these components. Our goal is primarily to bring the latest version into JP, then replace it with our unified number-formatters component.

Update/Latest: @automattic/format-currency is no longer in use anywhere within JP by now, so internalising these methods, albeit not the grand solution, is at least a step in the right direction (to allow us to deprecate @automattic/format-currency completely - remove it from the wp-calypso monorepo). All code has migrated to @automattic/number-formatters at this point. This is just a follow-up on #42456

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 14, 2025 •
edited
Loading

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack or WordPress.com Site Helper), and enable the update/i18n-internalize-currencies-object branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack update/i18n-internalize-currencies-object

bin/jetpack-downloader test jetpack-mu-wpcom-plugin update/i18n-internalize-currencies-object

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions github-actions bot added [Block] Donations [JS Package] Components [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Status] In Progress RNA labels Mar 14, 2025
@chriskmnds chriskmnds changed the title i18n: Internalise legacy CURRENCIES object from format-currency i18n: Internalise legacy CURRENCIES object from @automattic/format-currency Mar 14, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 14, 2025 •
edited
Loading

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

Jetpack plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@github-actions github-actions bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Mar 14, 2025
@chriskmnds chriskmnds self-assigned this Mar 14, 2025
@jp-launch-control
Copy link
Copy Markdown

jp-launch-control bot commented Mar 14, 2025 •
edited
Loading

Code Coverage Summary

Coverage changed in 1 file.

File Coverage Δ% Δ Uncovered
projects/plugins/jetpack/extensions/shared/currencies.js 11/24 (45.83%) 4.92% 0 💚

Full summary · PHP report · JS report

@chriskmnds chriskmnds requested a review from jeherve March 14, 2025 10:42
@chriskmnds chriskmnds mentioned this pull request Mar 31, 2025
Merged
3 tasks
@chriskmnds chriskmnds force-pushed the update/i18n-internalize-get-currency-defaults branch 2 times, most recently from fc1c99b to df63435 Compare May 7, 2025 09:53
@chriskmnds chriskmnds force-pushed the update/i18n-internalize-currencies-object branch from 2453adb to 1d33313 Compare May 7, 2025 09:57
@chriskmnds chriskmnds marked this pull request as ready for review May 7, 2025 11:42
@chriskmnds chriskmnds requested a review from a team May 7, 2025 11:43
Base automatically changed from update/i18n-internalize-get-currency-defaults to trunk May 8, 2025 08:23
@github-actions github-actions bot added the [Block] Pay With Paypal aka Simple Payments label May 8, 2025
@chriskmnds chriskmnds force-pushed the update/i18n-internalize-currencies-object branch from 1d33313 to 74ff52f Compare May 8, 2025 08:28
@chriskmnds chriskmnds mentioned this pull request May 9, 2025
Closed
3 tasks
@jeherve jeherve added the Enhancement Changes to an existing feature — removing, adding, or changing parts of it label May 12, 2025
sirbrillig
sirbrillig reviewed May 12, 2025
View reviewed changes
projects/plugins/jetpack/extensions/shared/currencies.js

/**
* Currency data for formatting currencies.
* This is an internalized version of the CURRENCIES object previously imported from format-currency.
Copy link
Copy Markdown
Member

@sirbrillig sirbrillig May 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a note that reads something like:

IMPORTANT: currency formatting is dependent on locale, not on currency code, so using `grouping` and `decimal` here will provide inaccurate results. Please use `@automattic/number-formatters` package for formatting.

Copy link
Copy Markdown
Contributor Author

@chriskmnds chriskmnds May 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sirbrillig ! Certainly. I need to rebase here, and it might be the case we no longer need this variable if #43418 suffices to migrate the donations block straight into using @automattic/number-formatters (without the separate currency symbol rendering). I still need to test that, so will return here once done.

@chriskmnds
Copy link
Copy Markdown
Contributor Author

chriskmnds commented May 12, 2025

Moving this back to draft - will return here once #43418 is ready 🙇

@chriskmnds chriskmnds marked this pull request as draft May 12, 2025 16:53
@chriskmnds chriskmnds mentioned this pull request May 20, 2025
Closed
8 tasks
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 20, 2025

This PR has been marked as stale. This happened because:

  • It has been inactive for the past 3 months.
  • It hasn't been labeled `[Pri] BLOCKER`, `[Pri] High`, `[Status] Keep Open`, etc.

If this PR is still useful, please do a [trunk merge or rebase](https://github.com/Automattic/jetpack/blob/trunk/docs/git-workflow.md#keeping-your-branch-up-to-date) and otherwise make sure it's up to date and has clear testing instructions. You may also want to ping possible reviewers in case they've forgotten about it. Please close this PR if you think it's not valid anymore — if you do, please add a brief explanation.

If the PR is not updated (or at least commented on) in another month, it will be automatically closed.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 21, 2025

This PR has been automatically closed as it has not been updated in some time. If you want to resume work on the PR, feel free to restore the branch and reopen the PR.

@github-actions github-actions bot closed this Sep 21, 2025
@github-actions github-actions bot deleted the update/i18n-internalize-currencies-object branch September 21, 2025 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sirbrillig sirbrillig sirbrillig left review comments

@jeherve jeherve Awaiting requested review from jeherve

Assignees

@chriskmnds chriskmnds

Labels

[Block] Donations [Block] Pay With Paypal aka Simple Payments Enhancement Changes to an existing feature — removing, adding, or changing parts of it [JS Package] Components [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ RNA [Status] In Progress [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. [Status] Stale

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chriskmnds @sirbrillig @jeherve