Skip to content

i18n: Internalise legacy getCurrencyDefaults method from @automattic/format-currency#42456

Merged
chriskmnds merged 2 commits intotrunkfrom
update/i18n-internalize-get-currency-defaults
May 8, 2025
Merged

i18n: Internalise legacy getCurrencyDefaults method from @automattic/format-currency#42456
chriskmnds merged 2 commits intotrunkfrom
update/i18n-internalize-get-currency-defaults

Conversation

@chriskmnds
Copy link
Copy Markdown
Contributor

@chriskmnds chriskmnds commented Mar 14, 2025 •
edited
Loading

Part of a PT: pxLjZ-9ME-p2
Partly addresses https://github.com/Automattic/i18n-issues/issues/939 and https://github.com/Automattic/i18n-issues/issues/942

Proposed changes:

Before we can consolidate number and currency formatting in Jetpack we need to bring @automattic/format-currency to the latest version (2.0.0). We internalise some of the legacy functionality that's no longer present in format-currency so we upgrade.

Fixing these cases (to remove the legacy code completely) can be done separately by folks more familiar with these components. Our goal is primarily to bring the latest version into JP, then replace it with our unified number-formatters component.

Update/Latest: @automattic/format-currency is no longer in use anywhere within JP by now, so internalising these methods, albeit not the grand solution, is at least a step in the right direction (to allow us to deprecate @automattic/format-currency completely - remove it from the wp-calypso monorepo). All code has migrated to @automattic/number-formatters at this point.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

Screenshot 2025-05-07 at 2 41 19 PM

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 14, 2025 •
edited
Loading

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the update/i18n-internalize-get-currency-defaults branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack update/i18n-internalize-get-currency-defaults

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions github-actions bot added [Block] Pay With Paypal aka Simple Payments [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Status] In Progress labels Mar 14, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 14, 2025 •
edited
Loading

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • 🔴 Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

Jetpack plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@github-actions github-actions bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Mar 14, 2025
@jp-launch-control
Copy link
Copy Markdown

jp-launch-control bot commented Mar 14, 2025 •
edited
Loading

Code Coverage Summary

Coverage changed in 1 file.

File Coverage Δ% Δ Uncovered
projects/plugins/jetpack/extensions/shared/currencies.js 9/22 (40.91%) 2.81% 0 💚

Full summary · PHP report · JS report

@chriskmnds chriskmnds self-assigned this Mar 14, 2025
@chriskmnds chriskmnds requested a review from jeherve March 14, 2025 10:42
@chriskmnds chriskmnds mentioned this pull request Mar 31, 2025
Merged
3 tasks
@chriskmnds chriskmnds force-pushed the update/i18n-internalize-get-currency-defaults branch from 8f3da28 to c01ad2b Compare May 7, 2025 09:43
@chriskmnds chriskmnds changed the base branch from trunk to update/i18n-number-formatters-currencies-export May 7, 2025 09:45
@chriskmnds chriskmnds changed the base branch from update/i18n-number-formatters-currencies-export to trunk May 7, 2025 09:50
@chriskmnds chriskmnds force-pushed the update/i18n-internalize-get-currency-defaults branch from fc1c99b to df63435 Compare May 7, 2025 09:53
@chriskmnds chriskmnds marked this pull request as ready for review May 7, 2025 11:41
@chriskmnds chriskmnds requested a review from a team May 7, 2025 11:42
@chriskmnds chriskmnds mentioned this pull request May 7, 2025
Closed
3 tasks
dlind1
dlind1 approved these changes May 7, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@dlind1 dlind1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked fine with Simple Payments / Pay with PayPal button.

Screenshot 2025-05-07 at 23 32 47

@chriskmnds
Copy link
Copy Markdown
Contributor Author

chriskmnds commented May 8, 2025

Thanks @dlind1 . I could not connect a Stripe account for some reason. I was attempting through one of the accounts in the secret store 🤷‍♂️

@chriskmnds chriskmnds merged commit d162cbc into trunk May 8, 2025
68 of 69 checks passed
@chriskmnds chriskmnds deleted the update/i18n-internalize-get-currency-defaults branch May 8, 2025 08:23
@github-actions github-actions bot removed [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. [Status] In Progress labels May 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dlind1 dlind1 dlind1 approved these changes

@jeherve jeherve Awaiting requested review from jeherve

Assignees

@chriskmnds chriskmnds

Labels

[Block] Pay With Paypal aka Simple Payments [JS Package] Number Formatters [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ RNA

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@chriskmnds @dlind1