Social: Update share status modal to use Dataviews component#39230
Social: Update share status modal to use Dataviews component#39230manzoorwanijk merged 11 commits intotrunkfrom
Conversation
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Follow this PR Review Process:
Still unsure? Reach out in #jetpack-developers for guidance! |
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
| }, | ||
| { | ||
| id: 'timestamp', | ||
| label: __( 'Time', 'jetpack' ), |
There was a problem hiding this comment.
I think it would be better to call this Shared at or something similar
There was a problem hiding this comment.
Then the continuation of the sentence doesn't read nice "Shared at 2 minutes ago", where as, "Time" can be read as its own clause.
There was a problem hiding this comment.
To me, time feels too vague, also I looked up on the designs it's 'Published at' on the admin page, maybe that's where I got the idea from :D I think Shared at still makes more sense than published at. Either way we should use the same term here and there in the future, even if that's time
There was a problem hiding this comment.
But what about the case of failure? We can't say "Shared at".
There was a problem hiding this comment.
That's a point we have to make on the admin page designs too, but let's leave time now then
|
Build failure being discussed at p1725456184868289-slack-C05Q5HSS013 |
gmjuhasz
left a comment
There was a problem hiding this comment.
This looks a lot better thanks for the refactor!
Just a minor comment, the View ExternalLink changed to black from the previous color, can we retain that?
Fixed. Thanks 
|
* Add @wordpress/dataviews as a dependency * Create and use the dataview component * Do some makeup * Render and clean up * Add changelog * Copy paste clean up from previous PR * Pass data from parent to avoid duplication * Use only the styles from dataviews for now * Restore link styles * Add a comment about the color
Share status modal on mobile looks messed up. See #39051 (comment)
Proposed changes:
Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions:
define( 'JETPACK_SOCIAL_HAS_SHARE_STATUS', true );