Skip to content

Related Posts: avoid notices in Woocommerce setup screen.#3688

Merged
kraftbj merged 1 commit intomasterfrom
fix/woocommerce-notices
Jun 9, 2016
Merged

Related Posts: avoid notices in Woocommerce setup screen.#3688
kraftbj merged 1 commit intomasterfrom
fix/woocommerce-notices

Conversation

@jeherve
Copy link
Copy Markdown
Member

@jeherve jeherve commented Apr 19, 2016

Fix Notices thrown on admin_init hook.

screen shot 2016-04-19 at 5 49 15 pm

Related: #3077

@jeherve jeherve added Bug When a feature is broken and / or not performing as intended [Feature] Related Posts [Status] Needs Review This PR is ready for review. labels Apr 19, 2016
@jeherve jeherve added this to the 4.0.1 milestone Apr 19, 2016
@kraftbj kraftbj added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Apr 19, 2016
@jeherve jeherve modified the milestones: 4.0.1, 4.0.2, 4.0.3 Apr 21, 2016
@jeherve jeherve mentioned this pull request Apr 26, 2016
Closed
@jeherve jeherve modified the milestones: 4.0.3, 4.0.4 May 11, 2016
@eliorivero eliorivero force-pushed the fix/woocommerce-notices branch from e4909e9 to 8ec8bb8 Compare June 3, 2016 20:00
@jeherve @eliorivero
Related Posts: avoid notices in Woocommerce setup screen.
8ec8bb8 
Fix Notices thrown on `admin_init` hook.

Related: #3077
@eliorivero
Copy link
Copy Markdown
Contributor

eliorivero commented Jun 3, 2016

LGTM :shipit: This fixes the issue.

I've rebased it because it had a conflict with new files created by gulp

css/dashboard-widget.css
css/dashboard-widget.css.map
css/dashboard-widget.min.css
css/jetpack-admin-jitm.css
css/jetpack-admin-jitm.css.map
css/jetpack-admin-jitm.min.css

it's clean now and good to go.

@kraftbj kraftbj merged commit 7cb850f into master Jun 9, 2016
@matticbot matticbot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Jun 9, 2016
kraftbj pushed a commit that referenced this pull request Jun 9, 2016
@jeherve @kraftbj
Related Posts: avoid notices in Woocommerce setup screen. (#3688)
20f28b2 
Fix Notices thrown on `admin_init` hook.

Related: #3077
@kraftbj
Copy link
Copy Markdown
Contributor

kraftbj commented Jun 9, 2016

Cherry-picked into branch-4.0 by 20f28b2

@kraftbj kraftbj deleted the fix/woocommerce-notices branch June 9, 2016 17:09
jeherve added a commit that referenced this pull request Jun 13, 2016
@jeherve
Release Notes: add #3748, #4081, #3688
5cc06d3
jeherve added a commit that referenced this pull request Jun 14, 2016
@jeherve
Release Notes: add #3748, #4081, #3688
61c9399
@jeherve jeherve mentioned this pull request Jun 15, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Bug When a feature is broken and / or not performing as intended [Feature] Related Posts Touches WP.com Files

Projects

None yet

Milestone

4.0.4

Development

Successfully merging this pull request may close these issues.

5 participants

@jeherve @eliorivero @kraftbj @samhotchkiss @matticbot