Site properties in wp_blogs must be integers#3414
Merged
dereksmart merged 1 commit intoAutomattic:masterfrom Feb 17, 2016
Merged
Site properties in wp_blogs must be integers#3414dereksmart merged 1 commit intoAutomattic:masterfrom
dereksmart merged 1 commit intoAutomattic:masterfrom
Conversation
Member
|
Related: 5b6bbc0 |
Contributor
|
@kovshenin thanks for the PR! It turns out that we have another PR that looks like it will solve your problem: #3405. Can you please test it and see if it's good for that old schema? |
Contributor
Author
|
|
Contributor
|
OK, thanks for taking a look! We'll get one of those solutions in for 3.9.2. |
Contributor
|
Let's get this in for 3.9.2 and then deal with the other PR for 4.0. |
dereksmart
added a commit
that referenced
this pull request
Feb 17, 2016
Site properties in wp_blogs must be integers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It looks like #2381 broke some WordPress installations with outdated database schemas.
The archived column used to be an enum and not a tinyint, so when selecting
archived = ''it returns no rows. A couple of ALTER TABLE statements fixes the bug (though I haven't tested with strict SQL mode) but it's easy enough for us to take care of that by providing integer values instead of empty strings. It's what core does inwp_get_sites()too.