Skip to content

Social: Fix store/initial-state out of sync issue#33969

Merged
gmjuhasz merged 4 commits intotrunkfrom
fix/social-store-refresh-issue
Nov 6, 2023
Merged

Social: Fix store/initial-state out of sync issue#33969
gmjuhasz merged 4 commits intotrunkfrom
fix/social-store-refresh-issue

Conversation

@gmjuhasz
Copy link
Copy Markdown
Contributor

@gmjuhasz gmjuhasz commented Nov 6, 2023

In our store, a feature is available if the main Jetpack Social toggle is on. Right now if you have Jetpack Social off, and go to the settings page, turning Jetpack Social on will show SIG and auto conversion off even if they are on in the settings, as the initial state was loaded with Jetpack Social off

Proposed changes:

  • Refresh the store from the blog options when we turn Jetpack Social on

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

https://github.com/orgs/Automattic/projects/733/views/2?pane=issue&itemId=43051048

Does this pull request change what data or activity we track or use?

No.

Testing instructions:

  • Open up your site and turn off Jetpack Social off on the admin page. Refresh the page and turn it on.
  • After loading the features should be on if they were on before turning the feature off
  • Without this change following these steps will show the features being off.

@gmjuhasz gmjuhasz added the [Status] Needs Team Review Obsolete. Use Needs Review instead. label Nov 6, 2023
@gmjuhasz gmjuhasz requested a review from a team November 6, 2023 10:02
@gmjuhasz gmjuhasz self-assigned this Nov 6, 2023
@github-actions github-actions bot added [JS Package] Publicize Components [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Plugin] Social Issues about the Jetpack Social plugin [Status] In Progress Admin Page React-powered dashboard under the Jetpack menu RNA labels Nov 6, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 6, 2023

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

  • WordPress.com Simple releases happen daily.
  • WoA releases happen weekly.
  • Releases to self-hosted sites happen monthly. The next release is scheduled for December 5, 2023 (scheduled code freeze on November 28, 2023).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Social plugin:

  • Next scheduled release: December 5, 2023.
  • Scheduled code freeze: November 27, 2023.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 6, 2023 •
edited
Loading

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the fix/social-store-refresh-issue branch.

  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack fix/social-store-refresh-issue

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@gmjuhasz gmjuhasz marked this pull request as ready for review November 6, 2023 10:23
manzoorwanijk
manzoorwanijk approved these changes Nov 6, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@manzoorwanijk manzoorwanijk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected

@gmjuhasz gmjuhasz merged commit 809535b into trunk Nov 6, 2023
@gmjuhasz gmjuhasz deleted the fix/social-store-refresh-issue branch November 6, 2023 13:10
@github-actions github-actions bot removed [Status] In Progress [Status] Needs Team Review Obsolete. Use Needs Review instead. labels Nov 6, 2023
ice9js pushed a commit that referenced this pull request Nov 6, 2023
@gmjuhasz @ice9js
Social: Fix store/initial-state out of sync issue (#33969)
644209f 
* Add option to refresh toggles

* Refresh on change on admin page

* Refresh on change in Jetpack settings

* changelog
@gmjuhasz gmjuhasz mentioned this pull request Nov 15, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@manzoorwanijk manzoorwanijk manzoorwanijk approved these changes

Assignees

@gmjuhasz gmjuhasz

Labels

Admin Page React-powered dashboard under the Jetpack menu [JS Package] Publicize Components [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Plugin] Social Issues about the Jetpack Social plugin RNA

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gmjuhasz @manzoorwanijk @ice9js @sdixon194