Widget Visibility: support custom post type archive pages #80#2982
Merged
samhotchkiss merged 4 commits intomasterfrom Apr 4, 2016
Merged
Widget Visibility: support custom post type archive pages #80#2982samhotchkiss merged 4 commits intomasterfrom
samhotchkiss merged 4 commits intomasterfrom
Conversation
Contributor
There was a problem hiding this comment.
This string "Show/Hide if user in certain custom post type archive." should be "Show/Hide if user is in a certain custom post type archive."
Contributor
|
Works good. Needs update to solve conflicts. |
da2d9d6 to
06c8cef
Compare
Member
|
Rebased. |
| <option value="date" <?php selected( "date", $rule['major'] ); ?>><?php echo esc_html_x( 'Date', 'Noun, as in: "This page is a date archive."', 'jetpack' ); ?></option> | ||
| <option value="page" <?php selected( "page", $rule['major'] ); ?>><?php echo esc_html_x( 'Page', 'Example: The user is looking at a page, not a post.', 'jetpack' ); ?></option> | ||
|
|
||
| <option value="post_type" <?php selected( "post_type", $rule['major'] ); ?>><?php echo esc_html_x( 'Post Type', 'Show/Hide if user is in a certain custom post type archive.', 'jetpack' ); ?></option> |
Contributor
There was a problem hiding this comment.
This is a very strange Translator Context comment
Member
There was a problem hiding this comment.
Indeed. Do we really need a comment there? "Post Type" seems pretty standard.
Contributor
There was a problem hiding this comment.
I agree. I've modified it following the wording of the one used for Page
Contributor
|
Tested, works well. I have adjusted the text, as well as refactored the markup a bit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes for #80 and #750
replaces #1599