Widget Visibility: support custom post type archive pages #80#1599
Closed
ivankristianto wants to merge 1 commit intoAutomattic:masterfrom
Closed
Widget Visibility: support custom post type archive pages #80#1599ivankristianto wants to merge 1 commit intoAutomattic:masterfrom
ivankristianto wants to merge 1 commit intoAutomattic:masterfrom
Conversation
Contributor
Author
|
Any plan to merge this PR? |
Contributor
|
Hi @ivankristianto, it's still on the roadmap. Thanks for your patience! |
Contributor
|
This needs a review for UX and some deeper testing, as this syncs up with WordPress.com It's probably not going to happen for 3.6, but let's try to make an effort to get this wrangled for 3.7 |
Contributor
|
This isn't going to make 3.7. @jessefriedman, can you take some ownership of this for 3.8? |
Contributor
|
@ivankristianto can we get a rebase? |
Member
|
@dereksmart rebasing now with branch: fix/widget-visibility-and-cpts |
Contributor
|
@jessefriedman sounds good. please Close this when you're done. |
|
Any news on this? |
Contributor
|
@jessefriedman is https://github.com/automattic/jetpack/tree/fix/widget-visibility-and-cpts ready to be PR'd? |
Member
|
@kraftbj no, unfortunately I ran into the problem with the rebase, fixing it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #80 and #750
cc @jeherve and @kraftbj please kindly review this PR