Skip to content

Change from old php4 style constructor.#2324

Merged
georgestephanis merged 3 commits intomasterfrom
issue/2323
Jul 7, 2015
Merged

Change from old php4 style constructor.#2324
georgestephanis merged 3 commits intomasterfrom
issue/2323

Conversation

@georgestephanis
Copy link
Copy Markdown
Contributor

@georgestephanis georgestephanis commented Jun 29, 2015

Fixes #2323

@georgestephanis
Change from old php4 style constructor.
5ee6abd 
This is getting deprecated, necessary code churn.
@georgestephanis georgestephanis mentioned this pull request Jun 29, 2015
Closed
@kraftbj kraftbj added Bug When a feature is broken and / or not performing as intended General labels Jun 29, 2015
@kraftbj
Copy link
Copy Markdown
Contributor

kraftbj commented Jun 30, 2015

@georgestephanis anything left outstanding on this or ready for review/merging? (After I fix the fatals that occur with Markdown...)

@jeherve jeherve modified the milestones: 3.7, 3.6 Jul 1, 2015
@kraftbj kraftbj added [Status] Needs Review This PR is ready for review. and removed [Status] In Progress labels Jul 2, 2015
@kraftbj
Copy link
Copy Markdown
Contributor

kraftbj commented Jul 2, 2015

Marking for review so we can get it into master for those on master and trunk.

@georgestephanis
Copy link
Copy Markdown
Contributor Author

georgestephanis commented Jul 3, 2015

@dereksmart: This needs to hit, at the very least at the 3.6.1 point release whenever that lands. It'd be nice to have it hit for 3.6, but at this point I'm not holding my breath.

@georgestephanis georgestephanis mentioned this pull request Jul 6, 2015
Merged
@danielbachhuber
Copy link
Copy Markdown
Contributor

danielbachhuber commented Jul 6, 2015

FWIW, this issue is currently bricking everyone's VIP Quickstart instances, which are set to auto-update trunk on cron

cc @joshbetz @nickdaugherty

@joshbetz
Copy link
Copy Markdown
Contributor

joshbetz commented Jul 6, 2015

FWIW, this issue is currently bricking everyone's VIP Quickstart instances, which are set to auto-update trunk on cron

Jetpack shouldn't update on cron, but we still obviously need to get this fixed.

@danielbachhuber
Copy link
Copy Markdown
Contributor

danielbachhuber commented Jul 6, 2015

Jetpack shouldn't update on cron

Er, I meant WordPress trunk

@jeherve jeherve modified the milestones: 3.6, 3.6.1 Jul 7, 2015
@georgestephanis
Copy link
Copy Markdown
Contributor Author

georgestephanis commented Jul 7, 2015

Well, now that 3.6 is shipped, let's just get #2324 merged in. I'll do it now.

@danielbachhuber Are you running Jetpack Trunk in that, or the release version?

georgestephanis added a commit that referenced this pull request Jul 7, 2015
@georgestephanis
Merge pull request #2324 from Automattic/issue/2323
e99374c 
Change from old php4 style constructor.
@georgestephanis georgestephanis merged commit e99374c into master Jul 7, 2015
@georgestephanis georgestephanis removed the [Status] Needs Review This PR is ready for review. label Jul 7, 2015
@georgestephanis georgestephanis deleted the issue/2323 branch July 7, 2015 15:32
@danielbachhuber
Copy link
Copy Markdown
Contributor

danielbachhuber commented Jul 7, 2015

Well, now that 3.6 is shipped, let's just get #2324 merged in. I'll do it now.

Thanks!

Are you running Jetpack Trunk in that, or the release version?

I'm running trunk — I have a cron entry to auto-update.

@anomiex anomiex mentioned this pull request Oct 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Bug When a feature is broken and / or not performing as intended General

Projects

None yet

Milestone

3.6.1

Development

Successfully merging this pull request may close these issues.

5 participants

@georgestephanis @kraftbj @danielbachhuber @joshbetz @jeherve