Skip to content

Contact Form: avoid deprecation notice in WP 5.5#16569

Merged
jeherve merged 1 commit into
masterfrom
update/contact-form-new-disallowed-option
Jul 24, 2020
Merged

Contact Form: avoid deprecation notice in WP 5.5#16569
jeherve merged 1 commit into
masterfrom
update/contact-form-new-disallowed-option

Conversation

@jeherve

@jeherve jeherve commented Jul 24, 2020

Copy link
Copy Markdown
Member

Changes proposed in this Pull Request:

  • Contact Form: avoid deprecated notices when submitting a form

See https://make.wordpress.org/core/2020/07/23/codebase-language-improvements-in-5-5/

Primary issue: #15388

Jetpack product discussion

  • N/A

Does this pull request change what data or activity we track or use?

  • N/A

Testing instructions:

From 2 sites, both running this branch, one running WP 5.4.2 and another WP 5.5:

  • Activate contact form feature.
  • Add a form to a post
  • Under Settings > Discussion, add the word "jeremy" to the comment disallowed list.
  • View the post with your form, and submit a form with that word.
  • The form should be submitted successfully, with no notices in your log, and you should see the form submission in the Spam category in the Feedback menu in wp-admin.

Proposed changelog entry for your changes:

  • Contact Form: updates based on language improvements in WordPress 5.5.

@jeherve jeherve added this to the 8.8 milestone Jul 24, 2020
@jeherve jeherve requested a review from georgestephanis as a code owner July 24, 2020 14:00
@jeherve jeherve self-assigned this Jul 24, 2020
@matticbot

matticbot commented Jul 24, 2020

Copy link
Copy Markdown
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello jeherve! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer and confirm D46866-code works as expected before merging this PR. Once this PR is merged, please commit the changes to WP.com. Thank you!
This revision will be updated with each commit to this PR

@jeherve jeherve mentioned this pull request Jul 24, 2020
Closed
14 tasks
@kraftbj kraftbj mentioned this pull request Jul 24, 2020
Open
7 tasks
@jetpackbot

jetpackbot commented Jul 24, 2020 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

E2E results is available here (for debugging purposes): https://jetpack-e2e-dashboard.herokuapp.com/pr-16569

Scheduled Jetpack release: August 4, 2020.
Scheduled code freeze: July 28, 2020

Generated by 🚫 dangerJS against 42530d4

@jeherve jeherve force-pushed the update/contact-form-new-disallowed-option branch from a0067bb to 42530d4 Compare July 24, 2020 17:16
mdbitz
mdbitz approved these changes Jul 24, 2020
View reviewed changes

@mdbitz mdbitz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified name update per https://make.wordpress.org/core/2020/07/23/codebase-language-improvements-in-5-5/

Testing shows expected behavior.

@mdbitz mdbitz added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Jul 24, 2020
@jeherve jeherve merged commit d8777e6 into master Jul 24, 2020
@jeherve jeherve deleted the update/contact-form-new-disallowed-option branch July 24, 2020 17:39
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Jul 24, 2020
@jeherve

jeherve commented Jul 24, 2020

Copy link
Copy Markdown
Member Author

r210989-wpcom

jeherve added a commit that referenced this pull request Jul 28, 2020
@jeherve
Changelog: add #16569
659b9d5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mdbitz mdbitz mdbitz approved these changes
@georgestephanis georgestephanis Awaiting requested review from georgestephanis

Assignees

@jeherve jeherve

Labels

[Feature] Forms [Pri] Normal Touches WP.com Files [Type] Janitorial

Projects

None yet

Milestone

8.8

Development

Successfully merging this pull request may close these issues.

4 participants

@jeherve @matticbot @jetpackbot @mdbitz