Sync Health Tests: make messages easier to translate#15396
Merged
Conversation
Fixes #15379 I've also taken the opportunity to make the message with a number translatable differently depending on the number.
Collaborator
|
Thank you for the great PR description! When this PR is ready for review, please apply the Scheduled Jetpack release: May 5, 2020. |
jeherve
commented
Apr 9, 2020
mdbitz
previously approved these changes
Apr 10, 2020
Contributor
mdbitz
left a comment
There was a problem hiding this comment.
Nice use of wpkses and also _n for pluralization of minute(s)
Tested locally and screens display / function the same.
dereksmart
previously approved these changes
Apr 13, 2020
kbrown9
reviewed
Apr 14, 2020
Co-Authored-By: Kim Brown <50059399+kbrown9@users.noreply.github.com>
bisko
approved these changes
Apr 14, 2020
jeherve
added a commit
that referenced
this pull request
Apr 14, 2020
…15396) * Sync Health Tests: make messages easier to translate Fixes #15379 I've also taken the opportunity to make the message with a number translatable differently depending on the number. * Add missing period Co-Authored-By: Kim Brown <50059399+kbrown9@users.noreply.github.com> Co-authored-by: Kim Brown <50059399+kbrown9@users.noreply.github.com>
Member
Author
|
Cherry-picked to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15379
Changes proposed in this Pull Request:
This should make messages in the Site Health screen easier to translate, as per the feedback in #15379.
I've also taken the opportunity to make the message with a number translatable differently depending on the number.
Testing instructions:
/wp-admin/site-health.phpSync_Health::update_status( Sync_Health::STATUS_OUT_OF_SYNC )dropped into the wp.config.php or the functions theme file or etc.Sync_Health::update_status( Sync_Health::STATUS_IN_SYNC )define( 'JETPACK__SANDBOX_DOMAIN', 'badbadbad23434.example.com' );Proposed changelog entry for your changes: