Skip to content

Google Calendar block: Fix error message positioning#14833

Merged
mdbitz merged 1 commit intomasterfrom
fix/google-calendar-error-message
Feb 27, 2020
Merged

Google Calendar block: Fix error message positioning#14833
mdbitz merged 1 commit intomasterfrom
fix/google-calendar-error-message

Conversation

@apeatling
Copy link
Copy Markdown
Contributor

@apeatling apeatling commented Feb 27, 2020

When providing an invalid embed link fix the error message positioning.
Fixes #14824

Before:

75413065-9640d400-5978-11ea-87b8-1e26f8190bc1

After:

Screen Shot 2020-02-27 at 9 29 05 AM

Testing instructions:

  • Insert a Google Calendar block and provide an invalid embed link
  • Check the error message is aligned as per the screenshot above.

Proposed changelog entry for your changes:

None

@apeatling apeatling added Bug When a feature is broken and / or not performing as intended [Status] Needs Review This PR is ready for review. labels Feb 27, 2020
@apeatling apeatling requested a review from a team February 27, 2020 17:32
@apeatling apeatling self-assigned this Feb 27, 2020
@matticbot
Copy link
Copy Markdown
Contributor

matticbot commented Feb 27, 2020

Caution: This PR has changes that must be merged to WordPress.com
Hello apeatling! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer, review, and approve D39546-code before merging this PR. Thank you!

@jeherve jeherve added this to the 8.3 milestone Feb 27, 2020
@apeatling apeatling requested a review from a team February 27, 2020 17:33
@jetpackbot
Copy link
Copy Markdown
Collaborator

jetpackbot commented Feb 27, 2020

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: March 3, 2020.
Scheduled code freeze: February 25, 2020

Generated by 🚫 dangerJS against b557680

@mdbitz
Copy link
Copy Markdown
Contributor

mdbitz commented Feb 27, 2020

@apeatling Hi Andy, I was reviewing this and confirmed the margin is added to the notice. However I'm showing that all the content is centered. Seeing this on both twentysixteen & twentytwenty and wanted to confirm there wasn't anything to be concerned about.

Screen Shot 2020-02-27 at 1 45 46 PM

@apeatling
Copy link
Copy Markdown
Contributor Author

apeatling commented Feb 27, 2020

@mdbitz I'm not seeing the centering with twentytwenty, but I do see some odd font usage. I'll dig in a bit and see what's up. I don't think it's related to my change.

Screen Shot 2020-02-27 at 12 15 35 PM

@mdbitz
Copy link
Copy Markdown
Contributor

mdbitz commented Feb 27, 2020

:nod: I see the centering when I use master as well. I'm going to approve this and bring it across into 8.3 as its unrelated.

mdbitz
mdbitz approved these changes Feb 27, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@mdbitz mdbitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified margin is applied to the notice.

@mdbitz mdbitz merged commit 8d04b28 into master Feb 27, 2020
@mdbitz mdbitz deleted the fix/google-calendar-error-message branch February 27, 2020 20:34
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Needs Review This PR is ready for review. labels Feb 27, 2020
mdbitz pushed a commit that referenced this pull request Feb 27, 2020
@apeatling @mdbitz
[not verified] Google Calendar block: Fix error message positioning w…
7e42673 
…hen using an invalid embed code. (#14833)
@mdbitz
Copy link
Copy Markdown
Contributor

mdbitz commented Feb 27, 2020

Cherry Picked in : 7e42673

@pablinos
Copy link
Copy Markdown
Contributor

pablinos commented Feb 28, 2020

r203589-wpcom

@Copons Copons mentioned this pull request Mar 4, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mdbitz mdbitz mdbitz approved these changes

Assignees

@apeatling apeatling

Labels

[Block] Google Calendar Bug When a feature is broken and / or not performing as intended Touches WP.com Files

Projects

None yet

Milestone

8.3

Development

Successfully merging this pull request may close these issues.

Google Calendar block: lack of space around error notice

6 participants

@apeatling @matticbot @jetpackbot @mdbitz @pablinos @jeherve