SSO: Pass error value to wp_login_failed#14821
Merged
Conversation
Collaborator
|
Thank you for the great PR description! When this PR is ready for review, please apply the Scheduled Jetpack release: March 3, 2020. |
jeherve
approved these changes
Feb 27, 2020
Member
jeherve
left a comment
There was a problem hiding this comment.
This looks good to me. Merging.
mdbitz
added a commit
that referenced
this pull request
Feb 27, 2020
Contributor
|
cherry picked to branch-8.3 |
mdbitz
added a commit
that referenced
this pull request
Feb 27, 2020
Contributor
|
Changelog added in #14830 |
mdbitz
added a commit
that referenced
this pull request
Feb 27, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WP 5.4 now passes the authentication error via the wp_login_failed filter.
Adding this prevents notices, etc if code utilizes the new arg.
Open question for a future PR on if we should have been passing that error in the return. We haven't so don't want to conflate that with this.
Marking it for 8.3 late commit consideration to beat the Core release.
Changes proposed in this Pull Request:
Is this a new feature or does it add/remove features to an existing part of Jetpack?
Testing instructions:
Proposed changelog entry for your changes: