Clear rows for Related Posts: See #1091#1337
Closed
RCowles wants to merge 1 commit intoAutomattic:masterfrom
RCowles:1091-gh
Closed
Clear rows for Related Posts: See #1091#1337RCowles wants to merge 1 commit intoAutomattic:masterfrom RCowles:1091-gh
RCowles wants to merge 1 commit intoAutomattic:masterfrom
RCowles:1091-gh
Conversation
Contributor
|
There's weird stuff going on. Is css-janus supposed to modify class names? Looks like adding these comments might prevent it: |
Contributor
|
Just to be clear, do not merge until we resolve the class name flipping. (unless that's expected behavior) |
Contributor
|
As far as I know, |
Member
|
I think we should remove the left and right out of the class names. |
Contributor
|
I agree. |
RCowles
added a commit
that referenced
this pull request
Feb 9, 2015
Conflicts: css/jetpack-rtl.css css/jetpack.css
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempted to fix #1091 (see modules/related-posts/related-posts.css) but ran into some issues after running grunt. Looks like something strange with rtl. Submitting PR per @MichaelArestad's suggestion.