Skip to content

Masterbar: style Recovery mode button#12485

Merged
dereksmart merged 1 commit intomasterfrom
add/recovery-admin-button-colors
Jun 19, 2019
Merged

Masterbar: style Recovery mode button#12485
dereksmart merged 1 commit intomasterfrom
add/recovery-admin-button-colors

Conversation

@jeherve
Copy link
Copy Markdown
Member

@jeherve jeherve commented May 29, 2019

Changes proposed in this Pull Request:

The button was added in #12467.
This commit styles it so:

  • It looks similar to the core Recovery mode button when seeing the default Masterbar.
  • It uses the Calypso colors when the Masterbar is loaded by a user using Calypsoify

See discussion here to learn more about this:

#12467 (comment)

Before

After with the default Masterbar

screenshot 2019-05-29 at 16 22 59

After with Calypsoify on

screenshot 2019-05-29 at 16 22 29

Testing instructions:

  • In wp-includes/load.php, locate the wp_is_recovery_mode function. Set it to return true.
  • Under Jetpack > Settings > Writing, enable the WordPress.com Toolbar.
  • Go to http://yoursite/wp-admin/plugins.php?calypsoify=1
  • You should see the button looking as in the screenshot above, with Calypsoify on.
  • The button should disappear on mobile viewports.
  • Go to http://yoursite/wp-admin/
  • Calypsoify should now be disabled, and the button should still be there but in a different color, matching the screenshot above.

Proposed changelog entry for your changes:

  • WordPress.com Toolbar: add colors to Recovery Mode button.

The button was added in #12467.
This commit styles it so:
- It looks similar to the core Recovery mode button when seeing the default Masterbar.
- It uses the Calypso colors when the Masterbar is loaded by a user using Calypsoify
@jeherve jeherve added Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] Needs Review This PR is ready for review. [Status] Needs Design Review Design has been added. Needs a review! [Pri] Low [Feature] Masterbar WordPress.com Toolbar and Dashboard customizations [Feature] Calypsoify labels May 29, 2019
@jeherve jeherve added this to the 7.5 milestone May 29, 2019
@jeherve jeherve requested review from a team May 29, 2019 14:30
@jeherve jeherve self-assigned this May 29, 2019
@scottsweb scottsweb added [Status] Design Review Complete and removed [Status] Needs Design Review Design has been added. Needs a review! labels May 29, 2019
@scottsweb
Copy link
Copy Markdown
Contributor

This looks great to me 👍

@jetpackbot
Copy link
Copy Markdown
Collaborator

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: June 4, 2019.
Scheduled code freeze: May 28, 2019

Generated by 🚫 dangerJS against 3e715ba

@dereksmart dereksmart merged commit 873fe6f into master Jun 19, 2019
@dereksmart dereksmart deleted the add/recovery-admin-button-colors branch June 19, 2019 16:09
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Needs Review This PR is ready for review. labels Jun 19, 2019
jeherve added a commit that referenced this pull request Jun 20, 2019
jeherve added a commit that referenced this pull request Jun 27, 2019
The button was added in #12467.
This commit styles it so:
- It looks similar to the core Recovery mode button when seeing the default Masterbar.
- It uses the Calypso colors when the Masterbar is loaded by a user using Calypsoify
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Feature] Calypsoify [Feature] Masterbar WordPress.com Toolbar and Dashboard customizations [Pri] Low [Status] Design Review Complete

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants