Pass through the from parameter when connecting an already connected Jetpack#12351
Merged
emdashcodes merged 3 commits intomasterfrom May 15, 2019
Merged
Pass through the from parameter when connecting an already connected Jetpack#12351emdashcodes merged 3 commits intomasterfrom
from parameter when connecting an already connected Jetpack#12351emdashcodes merged 3 commits intomasterfrom
Conversation
Collaborator
This is an automated check which relies on |
kraftbj
reviewed
May 13, 2019
tyxla
reviewed
May 14, 2019
tyxla
reviewed
May 14, 2019
Author
|
Thanks for the reviews! I've moved the line inside the |
jeherve
requested changes
May 15, 2019
Member
jeherve
left a comment
There was a problem hiding this comment.
This should work. I only have a minor request until we have a whitelist of parameters.
jeherve
approved these changes
May 15, 2019
Member
|
Unblocking for now; as @tyxla mentioned it can be addressed in a future PR. @justinshreve You can merge whenever you're ready :) |
jeherve
added a commit
that referenced
this pull request
May 15, 2019
Follow-up from #12351 Since one can currently pass any "from" parameter when building that URL, let's sanitize that value.
jeherve
added a commit
that referenced
this pull request
May 21, 2019
…2380) * Connect flow: sanitize "from" parameter when building connect url Follow-up from #12351 Since one can currently pass any "from" parameter when building that URL, let's sanitize that value. * Connect URL: allow the use of periods in from parameter See #12380 (comment) Co-Authored-By: Marin Atanasov <8436925+tyxla@users.noreply.github.com> * Connect URL: escape full URL instead of sanitizing one parameter Co-authored-by: Eric Binnion <ericbinnion@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a user tries to connect Jetpack when the are already connected, they are redirected back to the onboarding flow in Calypso. See #3788.
Currently, if a
fromparameter is supplied (likewoocommerce-setup-wizard), this is lost during the redirect. We are going to start using this parameter in Calypso to show some different copy/design elements during the flow, so passing this along will help users who hit this edge case.To Test:
fromis also passed on retry. https://github.com/Automattic/wp-calypso/pull/32993/files#diff-4082b3f22f0a998cdc936b484d8ea8f9 and https://github.com/Automattic/wp-calypso/pull/32993/files#diff-ff76e1701bebf84cf3e5a847ffd165d0R171.&from=woocommerce-setup-wizardand make sure it persists back to Calypso (purple styles should be retained).