Skip to content

Stats: hide the Stats's widget title SVG in Screen Options.#11400

Merged
jeherve merged 1 commit intomasterfrom
fix/stats-svg-screen-options
Feb 25, 2019
Merged

Stats: hide the Stats's widget title SVG in Screen Options.#11400
jeherve merged 1 commit intomasterfrom
fix/stats-svg-screen-options

Conversation

@jeherve
Copy link
Copy Markdown
Member

@jeherve jeherve commented Feb 22, 2019

Fixes #11265

Changes proposed in this Pull Request:

In #10958 I changed the widget title and included a SVG file in there, not thinking that the widget title was also displayed in the Screen Options tab.

WordPress does not currently offer a filter allowing you to change the widget title in Screen Options but not inside the widgets, so I opted to hide that extra part of the widget title with CSS in the Screen Options tab.

Testing instructions:

  • Apply patch.
  • Run yarn build (or use JN)
  • Visit the main dashboard on a site connected to WordPress.com and with the Stats module active.
  • The stats dashboard widget title should not have changed, but it should only say "stats" in the Screen Options tab.

image
image

Proposed changelog entry for your changes:

  • Stats: do not show the Jetpack logo in the Stats dashboard widget title in the Screen Options tab.

Fixes #11265

In #10958 I changed the widget title and included a SVG file in there, not thinking that
the widget title was also displayed in the Screen Options tab.

WordPress does not currently offer a filter allowing you to change the widget title in
Screen Options but not inside the widgets, so I opted to hide that extra part of the
widget title with CSS in the Screen Options tab.
@jeherve jeherve added Bug When a feature is broken and / or not performing as intended [Feature] Stats Data Feature that enables users to track their site's traffic and gain insights on popular content. [Status] Needs Review This PR is ready for review. [Status] Needs Design Review Design has been added. Needs a review! labels Feb 22, 2019
@jeherve jeherve added this to the 7.1 milestone Feb 22, 2019
@jeherve jeherve self-assigned this Feb 22, 2019
@jeherve jeherve requested a review from a team February 22, 2019 17:22
@jetpackbot
Copy link
Copy Markdown
Collaborator

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: March 5, 2019.
Scheduled code freeze: February 26, 2019

Generated by 🚫 dangerJS against 84ac2a6

Copy link
Copy Markdown
Contributor

@keoshi keoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Design-wise, this looks great. Thanks for catching it @simison and thanks for fixing @jeherve !

@keoshi keoshi added [Status] Design Review Complete and removed [Status] Needs Design Review Design has been added. Needs a review! labels Feb 22, 2019
Copy link
Copy Markdown
Contributor

@brbrr brbrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@brbrr brbrr added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Feb 25, 2019
@ghost ghost removed the [Status] Ready to Merge Go ahead, you can push that green button! label Feb 25, 2019
@jeherve jeherve deleted the fix/stats-svg-screen-options branch February 25, 2019 14:33
@jeherve jeherve merged commit f2bcdc7 into master Feb 25, 2019
jeherve added a commit that referenced this pull request Feb 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug When a feature is broken and / or not performing as intended [Feature] Stats Data Feature that enables users to track their site's traffic and gain insights on popular content. [Pri] High [Status] Design Review Complete

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants