D23504-code. (newly created revision)

Looks great, works for me! 👍

@kwight @codebykat which endpoints are we testing against? relative to the site, or public.api?

Any other testing instructions?

For example, I used Jetpack Beta to test this but see:

Hmm. I tried it on jurassic.ninja and the new post_meta keys showed up right away when I switched to this branch. 🤔

@gwwar Maybe you need to have the Likes module activated?

Ahh okay confirmed you have to have Likes enabled in the Jetpack Settings or it won't load the module (which makes sense):

So. Now there's some weirdness, because it doesn't load if you toggle Sharing Buttons and not likes. But on the WPCOM side, both of these are handled in the Likes plugin; on the Jetpack side, the sharing stuff is overridden when Sharedaddy loads.

Let me think about how best to handle this.

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: February 5, 2019.
Scheduled code freeze: January 29, 2019

Generated by 🚫 dangerJS against 2f7385f

Okay - Updated to register the meta within the appropriate module. This works correctly on WPCOM as well because sharing.php is in Fusion.

Now when you test on the v2 API, you should see the post_meta enabled with whichever feature you have enabled under Settings:

With Likes enabled, switch_like_status should be in the meta:

With sharing buttons toggled on, sharing_disabled will be added:

And when they're both enabled, you should see both:

Also worth noting These meta are confusingly named. A post with Likes disabled will have switch_like_status set to FALSE (assuming Likes are enabled on posts by default). A post with Sharing Buttons enabled will have sharing_disabled set to FALSE.

Updated! Thanks @jeherve 😄

@gwwar Just want to double-check that you're able to verify functionality with the modules enabled?

For testing purposes we can use this link: https://jurassic.ninja/create/?jetpack-beta&branch=add/enable-likes-and-sharing-postmeta-in-api&wp-debug-log

I can see the prop, but do we map this to another name on the Jetpack side @jeherve ? I can't get the endpoint to properly reflect values.

cc @codebykat if you find weird behavior like

Also worth noting These meta are confusingly named. A post with Likes disabled will have switch_like_status set to FALSE (assuming Likes are enabled on posts by default). A post with Sharing Buttons enabled will have sharing_disabled set to FALSE.

#11196 (comment) please update the top summary with new testing instructions.

I think the behavior is okay here, I'd prefer if we could write up the expected permutations so folks can manually verify.

Updated the summary and toggled back to Needs Review. I think we just need sign-off from someone on the Jetpack side.