Skip to content

Admin Page: Rename modulesettingsform High Order component to withModuleSettingsFormHelpers for clarity#10932

Merged
oskosk merged 3 commits intomasterfrom
update/rename-modulesettingsform
Dec 11, 2018
Merged

Admin Page: Rename modulesettingsform High Order component to withModuleSettingsFormHelpers for clarity#10932
oskosk merged 3 commits intomasterfrom
update/rename-modulesettingsform

Conversation

@oskosk
Copy link
Copy Markdown
Contributor

@oskosk oskosk commented Dec 11, 2018

This is just a rename for clarity

Changes proposed in this Pull Request:

  • Updates the name of the High Order Component to be more clear
  • Renames the file defining it for consistency.

Testing instructions:

  • Checkout this branch
  • Run yarn clean-client.
  • Run yarn build.
  • Confirm it builds properly.
  • Load the admin page, settings tab.
  • Confirm everything still works

Proposed changelog entry for your changes:

  • None needed

@oskosk oskosk added [Status] Needs Review This PR is ready for review. [Type] Janitorial labels Dec 11, 2018
@oskosk oskosk requested a review from a team December 11, 2018 12:39
@oskosk oskosk force-pushed the update/rename-modulesettingsform branch from 9fbc715 to 81d4101 Compare December 11, 2018 12:40
@jetpackbot
Copy link
Copy Markdown
Collaborator

jetpackbot commented Dec 11, 2018 •
edited
Loading

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: January 10, 2019.
Scheduled code freeze: January 3, 2019

Generated by 🚫 dangerJS against 0442877

@oskosk oskosk changed the title Admin Page Rane modulesettingsform High Order component to withModuleSettingsFormHelpers for clarity Admin Page: Rename modulesettingsform High Order component to withModuleSettingsFormHelpers for clarity Dec 11, 2018
@oskosk oskosk added the Admin Page React-powered dashboard under the Jetpack menu label Dec 11, 2018
@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Dec 11, 2018
jeherve
jeherve approved these changes Dec 11, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This look okay, and I don't immediately notice any issues with testing. 🚢

@oskosk oskosk merged commit 62571e8 into master Dec 11, 2018
@ghost ghost removed the [Status] Ready to Merge Go ahead, you can push that green button! label Dec 11, 2018
@oskosk oskosk deleted the update/rename-modulesettingsform branch December 11, 2018 13:30
jeherve added a commit that referenced this pull request Dec 11, 2018
@jeherve
Admin page: update new component to use new naming convention.
7e8b79a 
@see #10932
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeherve jeherve jeherve approved these changes

Assignees

No one assigned

Labels

Admin Page React-powered dashboard under the Jetpack menu [Type] Janitorial

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@oskosk @jetpackbot @jeherve @matticbot