Remove legacy config pages & related code#10669
Conversation
|
Thank you for the great PR description! When this PR is ready for review, please apply the Scheduled Jetpack release: April 29, 2019. |
|
This PR has been marked as stale. This happened because:
No further action is needed. But it's worth checking if this PR has clear testing instructions, is it up to date with master, and it is still valid. Feel free to close this issue if you think it's not valid anymore — if you do, please add a brief explanation. |
de8240b to
3f91d0d
Compare
cbb7b48 to
a3819f4
Compare
Search by translated module name.
`wp_get_custom_css()` was introduced in WordPress 4.7.
jeherve
left a comment
There was a problem hiding this comment.
This tests well for me. 👍
I would only recommend adding all the hooks that are now deprecated to deprecated_hooks, but that can be done in an additional PR.
|
I've manually added the relevant changes to code-D26734. |
I didn't know that was a thing :) Most of the hooks are dynamic: they contain the module slug. Any advice? |
That's a good question. I am not sure how we should handle, or if it should in fact. Maybe not that many third-parties are relying on those hooks today? |
Probably. We had a tendency to add theoretical hooks optimistic that someone would find them useful, but it was rare that anyone ever did. |
|
My only concern with this is if it breaks any no-js fallbacks, but we're probably okay with that. If the user uses the legacy modules page, is it possible to do some of this stuff any more? |
|
@georgestephanis legacy settings pages are not easily accessible anymore (except stats settings), so there quite a small chance that anyone is still using them. You still can access them by passing the correct url-params though. |
Do you mean "is it still possible to change the settings that you used to be able to change via the legacy pages", then yes: to the best of my knowledge all settings available on the legacy pages are available in the React UI as well. |
Follow-up PR for cleaning up unused code after #10668
Changes proposed in this Pull Request:
Jetpack::module_configuration_load(),Jetpack::module_configuration_head(),Jetpack::module_configuration_screen(),Jetpack::module_configuration_activation_screen()and relevant code.jetpack_module_configuration_head_{module},jetpack_module_configuration_load_{module},display_activate_module_setting_{module},jetpack_notices_update_settings,jetpack_module_configuration_screen_{module}actions.$_GET['configure']and all relevant code.Testing instructions:
Make sure that every module configuration link redirects to the desired location: (react) Jetpack Settings or wp-admin settings / other pages when applicable (for example for widgets):
Proposed changelog entry for your changes: