Added (string) typecast to $prop->getValue()' call on lib/../util/Log.php:163#459
Closed
RickKukiela wants to merge 1 commit intoAuthorizeNet:masterfrom
Closed
Added (string) typecast to $prop->getValue()' call on lib/../util/Log.php:163#459RickKukiela wants to merge 1 commit intoAuthorizeNet:masterfrom
$prop->getValue()' call on lib/../util/Log.php:163#459RickKukiela wants to merge 1 commit intoAuthorizeNet:masterfrom
Conversation
…is used as the 3rd parameter of a `preg_replace()` call. This call can and will return `NULL` in some circumstances, and passing a non-string value there will result in, at best, a deprecated error being thrown.
This was referenced Jun 21, 2024
Contributor
|
Hi @RickKukiela, Thank you for this PR. Unfortunately, absorbing this change and releasing it will take some time. Kindly be patient with us. -- Gabriel |
Author
|
All good! Thanks for confirming receipt :) |
gnongsie
added a commit
that referenced
this pull request
Sep 2, 2024
Contributor
|
Closing this PR as the fix has been added as part of a different commit. |
alex-galkin-hostaway
pushed a commit
to Hostaway/sdk-php
that referenced
this pull request
Oct 14, 2024
…e instead of relying on casting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses the possible bug still present in 2.0.3 which I discussed in this issue post:
#458