Dependency Review

Scanned Files

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly refactors the TypeScript configuration for the web project. By adopting the @vue/tsconfig/tsconfig.dom.json preset, the configuration becomes more concise and aligned with Vue's recommended best practices. This change not only simplifies maintenance by reducing manual option management but also implicitly introduces several beneficial compiler settings, enhancing type checking and module resolution for the Vue application.

Highlights

• Configuration Simplification: The TypeScript configuration now extends @vue/tsconfig/tsconfig.dom.json, replacing a large set of manually specified compiler options with a standardized preset.
• Adopted Vue-Recommended Settings: The project gains essential Vue-recommended TypeScript settings, including verbatimModuleSyntax, moduleDetection: "force", jsxImportSource: "vue", and resolveJsonModule, ensuring better compatibility and practices for Vue development.
• Redundant Settings Removed: Twelve compiler options that were already provided by the new preset have been removed, streamlining the configuration file.
• Obsolete Options Dropped: importHelpers was dropped as it's a no-op with noEmit: true and tslib not installed, and isolatedModules was removed as it's superseded by verbatimModuleSyntax.
• Project-Specific Overrides Maintained: Crucial project-specific settings such as baseUrl, paths (@/* alias), and types: ["vitest/globals"] have been preserved to maintain existing project structure and functionality.

No actionable comments were generated in the recent review. 🎉

Learnt from: CR
Repo: Aureliolo/synthorg PR: 0
File: CLAUDE.md:0-0
Timestamp: 2026-03-15T01:53:24.084Z
Learning: Applies to web/**/*.ts : Use fast-check for property-based testing in Vue with `fc.assert` + `fc.property`.

Learnt from: CR
Repo: Aureliolo/synthorg PR: 0
File: CLAUDE.md:0-0
Timestamp: 2026-03-15T01:53:24.084Z
Learning: Applies to web/**/*.ts : Use fast-check for property-based testing in Vue with `fc.assert` + `fc.property`.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Greptile Summary

This PR simplifies web/tsconfig.json by extending the @vue/tsconfig/tsconfig.dom.json preset instead of manually maintaining 12 compiler options, and gains several Vue-recommended settings (verbatimModuleSyntax, moduleDetection: "force", jsxImportSource: "vue", resolveJsonModule) in the process.

• Removed 12 compiler options that are now provided by the preset (target, module, moduleResolution, strict, jsx, allowImportingTsExtensions, noEmit, esModuleInterop, forceConsistentCasingInFileNames, skipLibCheck).
• Dropped importHelpers (correctly identified as a no-op without tslib and with noEmit: true) and isolatedModules (superseded by verbatimModuleSyntax from the preset).
• Retained project-specific overrides: baseUrl, paths (@/* alias), and types: ["vitest/globals"].
• @vue/tsconfig is already present as a devDependency (^0.9), so no new dependency is introduced.
• One minor consideration: the types array override completely replaces any types defined by the preset rather than merging with them — this is safe here because env.d.ts (included in the include list) handles Vite client types via triple-slash directive, but it's worth verifying explicitly.

Confidence Score: 5/5

• This PR is safe to merge — it is a well-contained configuration simplification with no runtime impact and a fully passing test suite.
• The change touches a single non-runtime file (tsconfig.json). The removed options are demonstrably redundant with the preset, the preset package is already installed, and the PR author validated type-check, build, and 520 tests all pass. The only non-trivial point (the types override behavior) is handled safely by env.d.ts.
• No files require special attention.

Important Files Changed

This is a comment left during a code review.
Path: web/tsconfig.json
Line: 8

Comment:
**`types` override silently drops any types defined in the preset**

TypeScript's `types` array does **not merge** with a parent config — it fully replaces it. If `@vue/tsconfig/tsconfig.dom.json` (v0.9) includes anything in its own `types` array (e.g. `vite/client`), this line will silently drop those entries.

In practice this appears safe because `env.d.ts` is included in the project and likely carries a `/// <reference types="vite/client" />` triple-slash directive. However, it's worth double-checking the preset's resolved `types` with:

```bash
node -e "console.log(require('@vue/tsconfig/tsconfig.dom.json').compilerOptions?.types)"
```

If the preset does define `types`, you may want to merge explicitly:

```suggestion
    "types": ["vite/client", "vitest/globals"]
```

How can I resolve this? If you propose a fix, please make it concise.

_{Last reviewed commit: 0a83d6d}