Fix #151: Improve wedge export ordering in MusicXML#897
Merged
hbitteur merged 1 commit intoAudiveris:masterfrom Mar 7, 2026
Merged
Fix #151: Improve wedge export ordering in MusicXML#897hbitteur merged 1 commit intoAudiveris:masterfrom
hbitteur merged 1 commit intoAudiveris:masterfrom
Conversation
Contributor
|
Thank you drtootsie for all your recent PR's.
I've seen them from my smartphone.
I will be able to really take care of them when I get back home within a
couple of days.
Remark: I noticed you made your PR's against the "master" branch, while
we develop on the "development" branch and use master only for releases.
Could you re-target them to development, if at all possible?
Thanks a lot for your contribution (and bravo for your understanding of
Audiveris internals!)
/Hervé
On 3/1/2026 5:16 PM, Pepper Pancoast wrote:
Refactored Wedge export in PartwiseBuilder to use a measure-level
iterator. This ensures that 'start' and 'stop' events are exported in
correct chronological order regardless of voice assignment, preventing
rendering issues in notation editors like MuseScore.
------------------------------------------------------------------------
You can view, comment on, or merge this pull request online at:
#897
Commit Summary
* 1439839
<1439839>
Fix #151: Improve wedge export ordering in MusicXML
File Changes
(2 files <https://github.com/Audiveris/audiveris/pull/897/files>)
* *M* app/src/main/java/org/audiveris/omr/score/PartwiseBuilder.java
<https://github.com/Audiveris/audiveris/pull/897/files#diff-a7a095488e6f106e2a4658472686d70ff98689b0d26987a4e8dfea0dff02e225>
(131)
* *M* app/src/main/java/org/audiveris/omr/sig/inter/WedgeInter.java
<https://github.com/Audiveris/audiveris/pull/897/files#diff-3b4c2e50dbb3430ee8e47578468c5ecf59350468af02636963d8eb5005b6a6f6>
(24)
Patch Links:
* https://github.com/Audiveris/audiveris/pull/897.patch
* https://github.com/Audiveris/audiveris/pull/897.diff
—
Reply to this email directly, view it on GitHub
<#897>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFIIGAWDH4G6Y5WKNWJDPBL4ORO53AVCNFSM6AAAAACWDMXJAOVHI2DSMVQWIX3LMV43ASLTON2WKOZUGAYDONRRG4ZDKNI>.
You are receiving this because you are subscribed to this
thread.Message ID: ***@***.***>
--
Hervé Bitteur
Audiveris OMR
www.audiveris.org <http://www.audiveris.org>
…--
This email has been checked for viruses by Avast antivirus software.
www.avast.com
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored Wedge export in PartwiseBuilder to use a measure-level iterator. This ensures that 'start' and 'stop' events are exported in correct chronological order regardless of voice assignment, preventing rendering issues in notation editors like MuseScore.