Conversation
Related to Audiveris#835
|
@aminya Several questions:
I think the last option would be the best solution. If it works... |
I've noticed that the app tends to freeze when attempting to convert books longer than 30 pages. I can provide a demonstration if needed. In general, modern 64-bit applications are designed to utilize memory efficiently, and it's the operating system's responsibility to manage that memory rather than the application itself. If we need to establish a limit, it would be wise to align it with the standards set by the OS based on the hardware capabilities. While introducing an environment variable could be beneficial, it appears to be an uncommon practice among applications. Typically, manual memory capping is only necessary in specific web server scenarios. I believe that the current default memory setting is rather conservative, which may hinder performance for the majority of users who have significantly more RAM. Older computers can still utilize previous versions of the software if necessary. |
So, in practice, how should we configure the installer? We could try to simply remove the upper limit, and let the OS/JVM do their best... |
|
I just made a simple test this morning, setting the upper limit to 20G (a memory amount I don't have on my PC, limited to ca. 8G). I didn't try to really use a huge amount of memory, though. Therefore, your PR (setting Xmx8G) is OK for me. This being said, why not going further by setting it to Xmx20G, as I tried? |
|
I manually reported your modification (-Xmx8G) in the packaging/build.gradle file Closing the PR. |
|
Thank you for merging. Cherry picking works |
The default should be unlimited preferably, but this at least increases the fixed max number to 8 GB.
Related to #835