feat(ui): display cache hit rate with one decimal place by Astro-Han · Pull Request #967 · Astro-Han/pawwork

Astro-Han · 2026-05-28T04:23:51Z

Summary

Round cache hit rate in session context panel to one decimal place instead of integer. Add optional fractionDigits parameter to percent() formatter so other percentage displays (e.g. context usage) remain unchanged. No related issue — this is a small self-contained enhancement.

Why

The current integer display loses precision on small hit rates (e.g. 7.1% shows as 7%). One decimal place gives a meaningful improvement without visual noise.

Related Issue

None.

Human Review Status

Approved by @Astro-Han

Review Focus

The percent() formatter now takes an optional second argument; verify only cache hit rate passes it (line 197 in tab.tsx), not the usage stat (line 238).
The formatter uses toLocaleString(locale, { minimumFractionDigits, maximumFractionDigits }) instead of toFixed to preserve locale-aware decimal separators.

Risk Notes

None. The change is backward-compatible: percent(value) without the second argument behaves identically to before.

How To Verify

bun test src/components/session/session-context-metrics.test.ts
  9 pass, 0 fail

bun x tsc --noEmit
  clean, no errors

PLAYWRIGHT_SNAP=1 bun run test:e2e:local -- e2e/snap/session-context-cache.snap.ts
  1 passed

Screenshots or Recordings

E2E snap grid generated at docs/design/preview/screenshots/session-context-cache.png — visually confirmed by @Astro-Han: cache hit rate displays 90.0% with one decimal place.

Checklist

Summary by CodeRabbit

Release Notes

Improvements
- Cache hit rate metric now displays with one decimal place for improved precision (e.g., "90.0%" instead of "90%").
- Enhanced cache hit rate calculation algorithm for more granular percentage accuracy in reporting.

Round cache hit rate to one decimal instead of integer, and add optional fractionDigits parameter to the percent formatter so other percentage displays are unaffected.

coderabbitai · 2026-05-28T04:23:58Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 1bff8f05-07da-41ac-80c5-9cdafa278338

📥 Commits

Reviewing files that changed from the base of the PR and between a72c2cb and 49690dd.

📒 Files selected for processing (5)

packages/app/e2e/snap/session-context-cache.snap.ts
packages/app/src/components/session/session-context-format.ts
packages/app/src/components/session/session-context-metrics.test.ts
packages/app/src/components/session/session-context-metrics.ts
packages/app/src/components/session/session-context-tab.tsx

📝 Walkthrough

Walkthrough

Cache hit rate display across the session context is refined to show decimal precision. The metric calculation rounds to finer granularity, the percent formatter gains optional fraction-digit control, and the tab display calls it with one decimal place; e2e and unit tests update their assertions.

Changes

Cache Hit Rate Decimal Precision

Layer / File(s)	Summary
Cache hit rate calculation rounding adjustment `packages/app/src/components/session/session-context-metrics.ts`	Cache hit rate rounding changes from multiplying by 100 to multiplying by 1000 then dividing by 10, enabling finer decimal precision.
Percent formatter with configurable precision `packages/app/src/components/session/session-context-format.ts`	The `percent` formatter in `createSessionContextFormatter` accepts an optional `fractionDigits` parameter to control minimum and maximum fraction digits when formatting percentages.
Cache hit rate display and validation `packages/app/src/components/session/session-context-tab.tsx`, `packages/app/src/components/session/session-context-metrics.test.ts`, `packages/app/e2e/snap/session-context-cache.snap.ts`	Session context tab calls `percent(value, 1)` to display cache hit rate with one decimal place; unit and e2e test assertions update to expect the new decimal values (7.1 and 90.0% respectively).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Astro-Han/pawwork#910: This PR's cache-hit-rate rounding and percent formatting refinements directly extend the session context cache hit rate display feature introduced in that PR.

Poem

🐰 A percentage blooms with decimal flair,
From coarse rounding to one digit's care.
Ninety point oh—not ninety flat—
The formatter dances; tests applaud at that! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately and concisely describes the main change: displaying cache hit rate with one decimal place precision.
Description check	✅ Passed	The PR description follows the template and provides all required sections: Summary, Why, Related Issue, Human Review Status, Review Focus, Risk Notes, How To Verify, Screenshots, and a complete Checklist.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch pawwork/cache-hit-rate-decimal

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

github-actions

Suggested priority: P2 (includes user-path files (packages/app/src/components/session/session-context-format.ts, packages/app/src/components/session/session-context-metrics.test.ts, packages/app/src/components/session/session-context-metrics.ts, packages/app/src/components/session/session-context-tab.tsx)).

P1/P0 are reserved for maintainer confirmation. Please relabel manually if this is a release blocker, security issue, data-loss risk, or updater/runtime failure.

gemini-code-assist

Code Review

This pull request updates the cache hit rate calculation and formatting to display with one decimal place (e.g., "90.0%" instead of "90%"). Feedback was provided regarding the cache hit rate calculation, pointing out that returning null when there are no cache reads but there are cache writes incorrectly hides the cache hit rate (showing "—" instead of "0.0%"). A suggestion was made to only return null when both reads and writes are zero or less.

…-decimal

github-actions · 2026-05-28T06:35:39Z

Perf delta summary

Comparator: pass

Profile / Scenario	interaction median	interaction worst	long task max	tbt	frame gap p95	frame gap max	jank count	cls	status
default / homepage-cold	24 -> 24 (0)	56 -> 32 (-24)	74 -> 70 (-4)	24 -> 20 (-4)	33.4 -> 16.8 (-16.6)	116.7 -> 116.7 (0)	3 -> 4 (+1)	0 -> 0 (0)	pass
default / long-session-input-lag	40 -> 48 (+8)	48 -> 48 (0)	0 -> 0 (0)	0 -> 0 (0)	16.8 -> 16.7 (-0.1)	16.8 -> 16.8 (0)	0 -> 0 (0)	0 -> 0 (0)	pass
default / session-streaming-long	40 -> 32 (-8)	72 -> 56 (-16)	0 -> 0 (0)	0 -> 0 (0)	16.8 -> 16.8 (0)	16.8 -> 16.8 (0)	0 -> 0 (0)	0 -> 0 (0)	pass
default / tool-call-expand	24 -> 24 (0)	24 -> 40 (+16)	0 -> 0 (0)	0 -> 0 (0)	16.7 -> 16.8 (+0.1)	16.7 -> 16.8 (+0.1)	0 -> 0 (0)	0 -> 0 (0)	pass
default / terminal-side-panel-open	40 -> 48 (+8)	48 -> 48 (0)	0 -> 0 (0)	0 -> 0 (0)	33.3 -> 33.3 (0)	33.3 -> 33.3 (0)	0 -> 0 (0)	0 -> 0 (0)	pass
default / session-scroll-reading	16 -> 16 (0)	32 -> 16 (-16)	0 -> 0 (0)	0 -> 0 (0)	33.4 -> 16.7 (-16.7)	33.4 -> 16.7 (-16.7)	0 -> 0 (0)	0 -> 0 (0)	pass

Bump PawWork desktop release version to 2026.5.29. Changes since v2026.5.28: - feat(settings): move Connections to Integrations + global toast monitor (#975) - feat(ui): display cache hit rate with one decimal place (#967) - fix: stabilize session opening state (#969) - fix(session): repair stale paginated question blockers (#962) - fix(ui): refit read-file icon into 0-20 viewBox (#964) - fix: allow running tools to expand - fix: add run lifecycle diagnostics - fix: harden Electron repair fallback - refactor: remove legacy theme choices - ci: stabilize e2e Playwright install and PR triage paths Verification: diff scope matches prior release bump (#958) — only the version string in packages/desktop-electron/package.json and the workspace entry in bun.lock. All CI checks green (e2e-artifacts required a rerun due to Playwright browser install flake unrelated to this change).

feat(ui): display cache hit rate with one decimal place

d9e1605

Round cache hit rate to one decimal instead of integer, and add optional fractionDigits parameter to the percent formatter so other percentage displays are unaffected.

github-actions Bot added app Application behavior and product flows ui Design system and user interface P2 Medium priority labels May 28, 2026

github-actions Bot reviewed May 28, 2026

View reviewed changes

Astro-Han added the enhancement New feature or request label May 28, 2026

gemini-code-assist Bot reviewed May 28, 2026

View reviewed changes

Comment thread packages/app/src/components/session/session-context-metrics.ts

Merge remote-tracking branch 'origin/dev' into pawwork/cache-hit-rate…

49690dd

…-decimal

Astro-Han merged commit d0fe7f2 into dev May 28, 2026
30 of 32 checks passed

Astro-Han deleted the pawwork/cache-hit-rate-decimal branch May 28, 2026 07:09

Astro-Han mentioned this pull request May 28, 2026

chore(release): bump desktop version to v2026.5.29 #978

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(ui): display cache hit rate with one decimal place#967

feat(ui): display cache hit rate with one decimal place#967
Astro-Han merged 2 commits into
devfrom
pawwork/cache-hit-rate-decimal

Astro-Han commented May 28, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented May 28, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Poem

❌ Failed checks (1 warning)

Uh oh!

github-actions Bot left a comment

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

Uh oh!

github-actions Bot commented May 28, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

Astro-Han commented May 28, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Why

Related Issue

Human Review Status

Review Focus

Risk Notes

How To Verify

Screenshots or Recordings

Checklist

Summary by CodeRabbit

Release Notes

Uh oh!

coderabbitai Bot commented May 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Poem

❌ Failed checks (1 warning)

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

github-actions Bot commented May 28, 2026

Perf delta summary

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Astro-Han commented May 28, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented May 28, 2026 •

edited

Loading