feat(session): trace lifecycle close provenance by Astro-Han · Pull Request #794 · Astro-Han/pawwork

Astro-Han · 2026-05-20T15:54:19Z

Summary

Adds lifecycle close provenance to run observability diagnostics. Instance reload/dispose paths now create bounded lifecycle action IDs, propagate them through run-state interrupts, and classify known local lifecycle closes separately from unknown scope closes.

Why

PR #788 added the run-level diagnostic spine for #783, but local scope-close failures still stopped at unknown_scope_close when the parent instance lifecycle action was missing. This PR makes exports answer whether an in-flight run was interrupted by InstanceStore.reload, dispose, disposeDirectory, or disposeAll without changing retry behavior or user-facing copy.

Related Issue

Part of #783. This does not close #783's related follow-up space, and it does not close #721 or #755.

Human Review Status

Pending

Review Focus

Whether lifecycle action IDs stay bounded and do not leak paths, prompts, or tool inputs.
Whether disposeAll fan-out correctly shares one parent action across affected in-flight runs.
Whether the run-state fallback keeps the true propagation point while adding lifecycle provenance.
Whether the review follow-up stack handling correctly preserves overlapping lifecycle actions.
Whether the processor context capture avoids static instance-directory reads in multi-instance paths.

Risk Notes

Diagnostic-only change: no automatic retry, UI copy, provider credentials, or runtime replacement.
Visible UI/copy check skipped: no visible UI or copy changed.
Platform/packaging check considered: this touches instance/session lifecycle only, with no macOS/Windows packaging, updater, signing, shell, permission, or installer surface.
[Bug] First-turn tool execution aborted without recorded source — model stops, user must resend #721 and [Bug] 30s LLM connect timeout aborts OpenAI reasoning streams (post-#729 residual) #755 behavior fixes remain separate; this PR only improves causal exports.

How To Verify

Run observability + run-state + export tests: bun test test/session/run-observability.test.ts test/session/run-state.test.ts test/session/export.test.ts --timeout 30000 — 54 pass, 0 fail
Typecheck: bun run typecheck from packages/opencode — passed
Whitespace check: git diff --check HEAD~2..HEAD — passed

Screenshots or Recordings

Not applicable — no visible UI changes.

Checklist

How to use this checklist:

Tick a box by replacing [ ] with [x]. Do not edit, add, or remove items.

The bot-applied label items can only be honestly ticked AFTER the PR is opened and the labeler / priority-triage bots have run — return to the PR description and tick them then.

Most items are required. The few that are conditional are explicitly marked (conditional); for those, leave unticked if they truly do not apply and explain why in Risk Notes. All other items must be ticked before requesting human review.

coderabbitai · 2026-05-20T15:54:28Z

Warning

Rate limit exceeded

@Astro-Han has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 32 minutes and 17 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: c6ef3e8c-e41f-4087-a105-485ece19fa26

📥 Commits

Reviewing files that changed from the base of the PR and between 120fea0 and acb7330.

📒 Files selected for processing (9)

packages/opencode/src/effect/runner.ts
packages/opencode/src/project/instance-store.ts
packages/opencode/src/session/lifecycle-provenance.ts
packages/opencode/src/session/processor.ts
packages/opencode/src/session/run-observability/recorder.ts
packages/opencode/src/session/run-observability/types.ts
packages/opencode/src/session/run-state.ts
packages/opencode/test/session/run-observability.test.ts
packages/opencode/test/session/run-state.test.ts

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch codex/i783-lifecycle-provenance

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

github-actions

Suggested priority: P2 (includes non-doc, non-test paths outside the low-risk bucket).

P1/P0 are reserved for maintainer confirmation. Please relabel manually if this is a release blocker, security issue, data-loss risk, or updater/runtime failure.

gemini-code-assist

Code Review

This pull request introduces a lifecycle provenance tracking system to categorize session interruptions, such as instance reloads or disposals. It adds a new lifecycle-provenance utility, updates the Runner and SessionRunState to propagate lifecycle metadata, and enhances the observability recorder to include these details in session summaries. Feedback identifies a potential race condition in the withLifecycleCloseAction utility due to the use of a global map with asynchronous operations, suggesting FiberRef as a safer alternative. Additionally, there is a concern regarding the use of a static Instance.directory reference in the session processor, which may not behave correctly in multi-instance environments.

Astro-Han · 2026-05-21T03:14:05Z

Back-reference from #808.

This merged lifecycle close provenance PR is a foundation for the Run Incident Framework. #808 keeps #794 as the provenance base and scopes the next work into lifecycle causality (#802), transport interruption classification (#803), and safe recovery UX (#804).

Add the first #808 RunIncident diagnostic/export layer so provider transport disconnects, partial tool input interruptions, cleanup/finalizer evidence, and materialized-but-not-executed tool boundaries are derived from ordered append-only evidence instead of mutable summary overwrites. This keeps the PR diagnostic-only: it adds structured sanitized run_incidents export while preserving legacy classification, summary_key, and retry_safety compatibility, without adding recovery UI, retry behavior, or provider SDK changes. Verification: - bun test test/session/run-observability.test.ts test/session/export.test.ts --timeout 30000 — passed - bun run typecheck — passed - git diff --check — passed - PR CI for #812 — all checks passed Review follow-ups: - Preserved newest terminal/cleanup anchors when bounded evidence exceeds the export cap. - Aligned stream phase derivation with provider progress and terminal cause. - Resolved all Gemini and CodeRabbit review threads. Related: #808, #803, #788, #794

Astro-Han added 2 commits May 20, 2026 23:48

feat(session): classify lifecycle close provenance

ba808da

feat(session): trace instance lifecycle close actions

bd73349

Astro-Han added enhancement New feature or request harness Model harness, prompts, tool descriptions, and session mechanics P2 Medium priority labels May 20, 2026

github-actions Bot reviewed May 20, 2026

View reviewed changes

gemini-code-assist Bot reviewed May 20, 2026

View reviewed changes

Comment thread packages/opencode/src/session/lifecycle-provenance.ts

Comment thread packages/opencode/src/session/processor.ts Outdated

fix(session): harden lifecycle provenance context

acb7330

Astro-Han merged commit 55fca04 into dev May 20, 2026
27 checks passed

Astro-Han deleted the codex/i783-lifecycle-provenance branch May 20, 2026 16:19

This was referenced May 21, 2026

[Task] Track harness improvement series #195

Closed

feat(session): add run incident diagnostics #812

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(session): trace lifecycle close provenance#794

feat(session): trace lifecycle close provenance#794
Astro-Han merged 3 commits into
devfrom
codex/i783-lifecycle-provenance

Astro-Han commented May 20, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented May 20, 2026 •

edited

Loading

Rate limit exceeded

Uh oh!

github-actions Bot left a comment

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Astro-Han commented May 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

Astro-Han commented May 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Why

Related Issue

Human Review Status

Review Focus

Risk Notes

How To Verify

Screenshots or Recordings

Checklist

Uh oh!

coderabbitai Bot commented May 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Rate limit exceeded

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Astro-Han commented May 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Astro-Han commented May 20, 2026 •

edited

Loading

coderabbitai Bot commented May 20, 2026 •

edited

Loading