fix(app): use last user message time in sidebar by Astro-Han · Pull Request #471 · Astro-Han/pawwork

Astro-Han · 2026-05-06T10:05:25Z

Summary

Wire PawWork sidebar session rows to the existing last-user-message timestamp helper.
Keep sidebar display time and time sorting on the same computed timestamp.
Add focused regression coverage for the row-building path that feeds the sidebar.
Avoid pinning child stores while reading loaded message caches for sidebar timestamps.

Why

The PawWork sidebar row builder in layout.tsx was still writing created: session.time.created, so a session could look stale after the user sent a new message. The existing pawworkSidebarSessionTime helper already has the intended contract: use the latest valid loaded user message time, otherwise fall back to session creation time.

Related Issue

Closes #470

Human Review Status

Pending. A human should make the final merge decision after reviewing the final diff and verification evidence.

Review Focus

Please check that the layout.tsx PawWork session window path now passes the per-session message cache into the shared helper without bootstrapping or pinning child stores, and that missing message caches still fall back to creation time.

Risk Notes

Low. This changes the timestamp source for loaded sidebar rows only. No backend API, persistence schema, desktop packaging, updater, or generated-file changes are included. Sorting by time changes with the displayed timestamp, which is intended for this bug.

The global session window is still selected by the existing created-time API window; this PR intentionally fixes only timestamps for rows already in the PawWork sidebar window.

How To Verify

TDD red check: focused app unit test failed before implementation because buildPawworkSidebarSessionRows was not exported.
Focused app tests: bun --cwd packages/app test --preload ./happydom.ts ./src/pages/layout/pawwork-session-source.test.ts -> 916 pass, 0 fail
App typecheck: bun --cwd packages/app typecheck -> tsgo -b completed successfully
Workspace typecheck: bun turbo typecheck -> 8 successful, 8 total
Diff check: git diff --check -> no whitespace errors
Desktop startup check: bun run dev:desktop built main/preload/renderer and started the Electron app, but this machine already had another PawWork dev Electron instance using the shared dev profile, so I could not complete the interactive sidebar click-through in this worktree.

Screenshots or Recordings

Not captured. The Electron manual path was blocked by an existing local PawWork dev instance using the shared ai.pawwork.desktop.dev profile. The code change is data wiring for existing sidebar UI, with no layout or copy changes.

Checklist

coderabbitai · 2026-05-06T10:05:36Z

Warning

Rate limit exceeded

@Astro-Han has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 4 minutes and 55 seconds before requesting another review.

To continue reviewing without waiting, purchase usage credits in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: d7e24e77-d80c-47aa-af4c-cc5fd19715a6

📥 Commits

Reviewing files that changed from the base of the PR and between 734483c and 895c3ca.

📒 Files selected for processing (3)

packages/app/src/pages/layout.tsx
packages/app/src/pages/layout/pawwork-session-source.test.ts
packages/app/src/pages/layout/pawwork-session-source.ts

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch codex/i470-sidebar-session-time

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

gemini-code-assist

Code Review

This pull request introduces the buildPawworkSidebarSessionRows utility function to centralize the logic for preparing session data for the sidebar. It refactors the Layout component to use this new function and includes corresponding unit tests. I have no feedback to provide.

Astro-Han · 2026-05-06T10:31:13Z

Review follow-up handled:

P2 child-store lifecycle: fixed in 895c3ca0b by reading the message cache with globalSync.child(session.directory, { bootstrap: false, pin: false }). This keeps the original no-bootstrap behavior and also avoids pinning stores just for sidebar timestamp calculation. I did not add a new accessor in this PR because the existing ChildOptions.pin contract already covers the immediate lifecycle risk without adding another global-sync API.
P3 missing-cache fallback coverage: fixed in 895c3ca0b with a row-builder test proving missing messagesForSession falls back to session.time.created.
P3 global window selection: intentionally not changed. [Bug] Sidebar session timestamp shows creation time instead of last user message time #470 is about timestamps for rows already in the PawWork sidebar window. Changing the global session window selection/pagination contract to last-user-message time would require backend/API or indexed query semantics and should be a separate product/API issue if desired.

Fresh checks after the follow-up:

Focused app tests: bun --cwd packages/app test --preload ./happydom.ts ./src/pages/layout/pawwork-session-source.test.ts -> 916 pass, 0 fail
App typecheck: bun --cwd packages/app typecheck -> tsgo -b completed successfully
Diff check: git diff --check -> no whitespace errors

Astro-Han · 2026-05-06T10:48:07Z

Latest review follow-up:

P3 child store creation/touching: not changing fix(app): use last user message time in sidebar #471 further. The PR already avoids bootstrap and pinning, which removes the lifecycle risk that mattered for this bug fix. Avoiding even ensureChild(...) requires a new global-sync cache-peek API and tests around child-store manager semantics, so I split that into [Task] Add non-creating child-store cache peek for sidebar timestamp reads #475 instead of expanding this timestamp fix.
P3 global session window selection: not changing fix(app): use last user message time in sidebar #471. This is the product/API follow-up already tracked in [Feature] Sort initial sidebar sessions by last user message time #473. fix(app): use last user message time in sidebar #471 intentionally fixes timestamps and sorting for rows already in the sidebar window; changing the first-window query/pagination contract belongs in [Feature] Sort initial sidebar sessions by last user message time #473.

Latest CI status checked after 895c3ca0: all visible PR checks are passing, including typecheck, unit-app, unit-desktop, unit-opencode, e2e-artifacts, CodeQL, and smoke-macos-arm64.

Root cause: PawWork sidebar rows could display a latest user-message timestamp after PR #471, but the initial session window was still selected by session creation time. An old root session with recent real user input could stay outside the first sidebar page. What changed: - Added experimental.session.list sort=activity for global root sessions. - Defined activityAt as latest eligible real user message time, falling back to session creation time. - Added deterministic activity pagination with activityAt desc and session id asc. - Excluded assistant-only updates, session.time.updated, compaction messages, and synthetic-only user messages from activity promotion. - Preserved real user messages that also carry synthetic reminder parts. - Updated PawWork sidebar initial window and row timestamp/sort logic to use backend activity metadata, with local parts-aware freshness only when eligibility is known. - Regenerated v2 SDK types for sort=activity, activityAt, and lastUserMessageAt. - Split oversized sidebar source tests into focused files. Verification: - bun --cwd packages/sdk/js build - bun --cwd packages/opencode test --timeout 30000 ./test/server/global-session-activity-list.test.ts ./test/server/global-session-list.test.ts -> 21 pass - bun --cwd packages/app test --preload ./happydom.ts ./src/pages/layout/pawwork-sidebar-session-time.test.ts ./src/pages/layout/pawwork-sidebar-session-rows.test.ts ./src/pages/layout/pawwork-session-window.test.ts -> 927 pass - bun --cwd packages/opencode typecheck - bun --cwd packages/app typecheck - bun turbo typecheck -> 8 successful - git diff --check - desktop focused checks were also run and passed before merge. - GitHub checks were green at head 76740c9. Known follow-ups intentionally not included: - Pinned or active sessions outside the activity first page still need activity-aware by-id hydration to avoid cold-start fallback to creation time. - Large local histories may need EXPLAIN/query benchmarks and possibly a materialized activity field or index. - lastUserMessageAt is optional and may be omitted in the edge case where the real user message timestamp equals session creation time; activityAt remains correct. Closes #473

fix(app): use last user message time in sidebar

3d48376

Astro-Han added bug Something isn't working P1 High priority app Application behavior and product flows labels May 6, 2026

gemini-code-assist Bot reviewed May 6, 2026

View reviewed changes

fix(app): avoid pinning sidebar timestamp stores

895c3ca

This was referenced May 6, 2026

[Feature] Sort initial sidebar sessions by last user message time #473

Closed

[Task] Split layout.tsx into agent-readable controllers #474

Closed

[Task] Add non-creating child-store cache peek for sidebar timestamp reads #475

Closed

Astro-Han merged commit 9f5ce8a into dev May 6, 2026
22 checks passed

Astro-Han deleted the codex/i470-sidebar-session-time branch May 6, 2026 10:52

Astro-Han mentioned this pull request May 6, 2026

feat(app): sort sidebar sessions by user activity #476

Merged

11 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(app): use last user message time in sidebar#471

fix(app): use last user message time in sidebar#471
Astro-Han merged 2 commits into
devfrom
codex/i470-sidebar-session-time

Astro-Han commented May 6, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented May 6, 2026 •

edited

Loading

Rate limit exceeded

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

Astro-Han commented May 6, 2026

Uh oh!

Astro-Han commented May 6, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

Astro-Han commented May 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Why

Related Issue

Human Review Status

Review Focus

Risk Notes

How To Verify

Screenshots or Recordings

Checklist

Uh oh!

coderabbitai Bot commented May 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Rate limit exceeded

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Astro-Han commented May 6, 2026

Uh oh!

Astro-Han commented May 6, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Astro-Han commented May 6, 2026 •

edited

Loading

coderabbitai Bot commented May 6, 2026 •

edited

Loading